-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the InfoListOrganism default bg color #4091
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4091 +/- ##
===========================================
- Coverage 83.25% 83.25% -0.01%
===========================================
Files 1881 1881
Lines 49008 49006 -2
Branches 5747 5747
===========================================
- Hits 40800 40798 -2
Misses 6144 6144
Partials 2064 2064 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New version is much better!
@americanrefugee could you confirm the screenshots now look as expected? I left some comments in the figma file for this, so I'd like to double check the changes. |
Yes, the screenshots look correct |
Content
Change the different colors used in
InfoListOrganism
for background color to a default value ofElementTheme.colors.bgSubtleSecondary
which can be overridden if needed.Motivation and context
Unify the component's look and feel, after some changes in the design components from @americanrefugee .
Screenshots / GIFs
There are a few of them, so it's better to look at the new recorded screenshots.
Tests
Check the screenshots / app look as expected.
Tested devices
Checklist