Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the InfoListOrganism default bg color #4091

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Dec 23, 2024

Content

Change the different colors used in InfoListOrganism for background color to a default value of ElementTheme.colors.bgSubtleSecondary which can be overridden if needed.

Motivation and context

Unify the component's look and feel, after some changes in the design components from @americanrefugee .

Screenshots / GIFs

There are a few of them, so it's better to look at the new recorded screenshots.

Tests

Check the screenshots / app look as expected.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7AAY7g

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (a26a02b) to head (5a5bc6c).
Report is 54 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4091      +/-   ##
===========================================
- Coverage    83.25%   83.25%   -0.01%     
===========================================
  Files         1881     1881              
  Lines        49008    49006       -2     
  Branches      5747     5747              
===========================================
- Hits         40800    40798       -2     
  Misses        6144     6144              
  Partials      2064     2064              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version is much better!

@jmartinesp jmartinesp added the PR-Misc For other changes label Jan 7, 2025
@jmartinesp jmartinesp marked this pull request as ready for review January 7, 2025 08:36
@jmartinesp jmartinesp requested a review from a team as a code owner January 7, 2025 08:36
@jmartinesp jmartinesp requested review from ganfra and removed request for a team January 7, 2025 08:36
@jmartinesp
Copy link
Member Author

@americanrefugee could you confirm the screenshots now look as expected? I left some comments in the figma file for this, so I'd like to double check the changes.

@americanrefugee
Copy link

@americanrefugee could you confirm the screenshots now look as expected? I left some comments in the figma file for this, so I'd like to double check the changes.

Yes, the screenshots look correct

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 7, 2025
@jmartinesp jmartinesp enabled auto-merge (squash) January 7, 2025 09:53
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 7, 2025
@jmartinesp jmartinesp merged commit bb74fed into develop Jan 7, 2025
33 of 34 checks passed
@jmartinesp jmartinesp deleted the misc/replace-info-list-background-color branch January 7, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants