Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more detail about the error when pusher registration fails. #4081

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 20, 2024

Will give more details in this dialog:

image

@bmarty bmarty added the PR-Misc For other changes label Dec 20, 2024
@bmarty bmarty requested a review from a team as a code owner December 20, 2024 15:04
@bmarty bmarty requested review from ganfra and removed request for a team December 20, 2024 15:04
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DAXgyw

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (800d6f0) to head (8cc7f1c).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...io/element/android/appnav/loggedin/LoggedInView.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4081   +/-   ##
========================================
  Coverage    83.24%   83.24%           
========================================
  Files         1881     1881           
  Lines        48983    48983           
  Branches      5743     5743           
========================================
  Hits         40777    40777           
  Misses        6143     6143           
  Partials      2063     2063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants