Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send caption with image and video #3803

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Send caption with image and video #3803

merged 5 commits into from
Nov 6, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 4, 2024

Content

Add a composer in the media preview to be able to add a caption to image and video.

Motivation and context

Closes #2573

Screenshots / GIFs

sendCaption.mp4

Tests

  • Sent an image or a video to a room
  • observe that you can optionally write a caption, which will be then rendered in the timeline.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 4, 2024 13:39
@bmarty bmarty requested review from ganfra and removed request for a team November 4, 2024 13:39
Copy link
Contributor

github-actions bot commented Nov 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/17sfkZ

@bmarty bmarty added the PR-Feature For a new feature label Nov 4, 2024
Copy link

sonarqubecloud bot commented Nov 4, 2024

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 93.15068% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (17ea2aa) to head (ddc4085).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/libraries/matrix/test/timeline/FakeTimeline.kt 0.00% 4 Missing ⚠️
...s/impl/messagecomposer/MessageComposerPresenter.kt 0.00% 0 Missing and 2 partials ⚠️
...ibraries/textcomposer/model/MessageComposerMode.kt 33.33% 2 Missing ⚠️
...mpl/attachments/preview/AttachmentsPreviewState.kt 75.00% 0 Missing and 1 partial ⚠️
...ent/android/libraries/textcomposer/TextComposer.kt 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3803      +/-   ##
===========================================
+ Coverage    82.90%   83.02%   +0.11%     
===========================================
  Files         1772     1772              
  Lines        44531    44614      +83     
  Branches      5225     5235      +10     
===========================================
+ Hits         36920    37040     +120     
+ Misses        5780     5745      -35     
+ Partials      1831     1829       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everypizza1
Copy link

Just went through and tested with a screen reader: it works fine, although the text "optional caption" isn't read.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 5, 2024
@bmarty bmarty enabled auto-merge November 5, 2024 14:22
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 5, 2024
@bmarty bmarty disabled auto-merge November 6, 2024 08:12
@bmarty bmarty merged commit 47d7eac into develop Nov 6, 2024
31 of 33 checks passed
@bmarty bmarty deleted the feature/bma/sendCaption branch November 6, 2024 08:13
@bmarty bmarty mentioned this pull request Nov 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add captions to sent image and video files
4 participants