-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send caption with image and video #3803
Conversation
Regular files are not previewed, but prevent caption as well there.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3803 +/- ##
===========================================
+ Coverage 82.90% 83.02% +0.11%
===========================================
Files 1772 1772
Lines 44531 44614 +83
Branches 5225 5235 +10
===========================================
+ Hits 36920 37040 +120
+ Misses 5780 5745 -35
+ Partials 1831 1829 -2 ☔ View full report in Codecov by Sentry. |
Just went through and tested with a screen reader: it works fine, although the text "optional caption" isn't read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Content
Add a composer in the media preview to be able to add a caption to image and video.
Motivation and context
Closes #2573
Screenshots / GIFs
sendCaption.mp4
Tests
Tested devices
Checklist