Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable element enterprise jobs in forks CI #3412

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Sep 6, 2024

Content

Disable element enterprise jobs in forks CI

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@yostyle yostyle requested a review from a team as a code owner September 6, 2024 09:44
@yostyle yostyle requested review from ganfra and removed request for a team September 6, 2024 09:44
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@yostyle yostyle marked this pull request as draft September 6, 2024 09:49
@jmartinesp
Copy link
Member

So I think this was why I changed the check a couple of months ago 😅 :

image

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

@yostyle yostyle force-pushed the yostyle/update_ci_forks branch from fcdc5a1 to 8a6f6ff Compare October 7, 2024 23:38
@bmarty
Copy link
Member

bmarty commented Oct 8, 2024

@yostyle looks like you have pushed commits on the wrong branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants