Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics | permanent vs temporary utd #7770

Merged

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Mar 29, 2024

Preliminary work for #7767

depends on #7769

Add support for permanent vs temporary UTD.
If an event is decrypted in less than 4s after decryption, it should be graced.
If it's decrypted in > 4s and less than 60s, we still report as an UTD but with the time to decrypt.
If after 60s it's not decrypted report as permanent UTD

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@BillCarsonFr BillCarsonFr changed the title Valere/permanent vs temporary utd Analytics | permanent vs temporary utd Mar 29, 2024
@BillCarsonFr BillCarsonFr changed the base branch from develop to valere/swiftify_decryption_tracker March 29, 2024 17:16
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 12.45%. Comparing base (95fd61f) to head (1d633e8).

Files Patch % Lines
Riot/Modules/Analytics/Analytics.swift 0.00% 2 Missing ⚠️
...t/Modules/Analytics/DecryptionFailureTracker.swift 95.23% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           valere/swiftify_decryption_tracker    #7770      +/-   ##
======================================================================
+ Coverage                               12.29%   12.45%   +0.15%     
======================================================================
  Files                                    1650     1651       +1     
  Lines                                  163903   163946      +43     
  Branches                                67293    67325      +32     
======================================================================
+ Hits                                    20156    20416     +260     
+ Misses                                 143108   142880     -228     
- Partials                                  639      650      +11     
Flag Coverage Δ
unittests 6.23% <93.93%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr self-assigned this Apr 2, 2024
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 merged commit 520d22a into valere/swiftify_decryption_tracker Apr 2, 2024
5 of 6 checks passed
@Velin92 Velin92 deleted the valere/permanent_vs_temporary_utd branch April 2, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants