Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump analytics event to v0.15.0 #7768

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Bump analytics event to v0.15.0 #7768

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6b7652
Bump analytics event to v0.15.0
BillCarsonFr Mar 27, 2024
6945e3f
Update changelog
BillCarsonFr Mar 27, 2024
31a2b12
code review
BillCarsonFr Mar 28, 2024
09af055
rename changelog
BillCarsonFr Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Riot.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/matrix-org/matrix-analytics-events",
"state" : {
"revision" : "2f5fa5f1e2f6c6ae1a47c33d953a3ce289167eb0",
"version" : "0.5.0"
"revision" : "44d5a0e898a71f8abbbe12afe9d73e82d370a9a1",
"version" : "0.15.0"
}
},
{
Expand Down
14 changes: 12 additions & 2 deletions Riot/Modules/Analytics/Analytics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,16 @@ extension Analytics {
let event = AnalyticsEvent.Error(
context: context,
cryptoModule: .Rust,
cryptoSDK: AnalyticsEvent.Error.CryptoSDK.Rust,
BillCarsonFr marked this conversation as resolved.
Show resolved Hide resolved
domain: .E2EE,
name: reason.errorName
// XXX not yet supported.
eventLocalAgeMillis: nil,
isFederated: nil,
isMatrixDotOrg: nil,
name: reason.errorName,
timeToDecryptMillis: nil,
userTrustsOwnIdentity: nil,
wasVisibleToUser: nil
)
capture(event: event)
}
Expand Down Expand Up @@ -355,7 +363,8 @@ extension Analytics: MXAnalyticsDelegate {

func trackCallError(with reason: __MXCallHangupReason, video isVideo: Bool, numberOfParticipants: Int, incoming isIncoming: Bool) {
let callEvent = AnalyticsEvent.CallError(isVideo: isVideo, numParticipants: numberOfParticipants, placed: !isIncoming)
let event = AnalyticsEvent.Error(context: nil, cryptoModule: nil, domain: .VOIP, name: reason.errorName)
let event = AnalyticsEvent.Error(context: nil, cryptoModule: nil, cryptoSDK: nil, domain: .VOIP, eventLocalAgeMillis: nil,
isFederated: nil, isMatrixDotOrg: nil, name: reason.errorName, timeToDecryptMillis: nil, userTrustsOwnIdentity: nil, wasVisibleToUser: nil)
capture(event: callEvent)
capture(event: event)
}
Expand Down Expand Up @@ -386,6 +395,7 @@ extension Analytics: MXAnalyticsDelegate {
let event = AnalyticsEvent.Composer(inThread: inThread,
isEditing: isEditing,
isReply: isReply,
messageType: AnalyticsEvent.Composer.MessageType.Text,
BillCarsonFr marked this conversation as resolved.
Show resolved Hide resolved
startsThread: startsThread)
capture(event: event)
}
Expand Down
2 changes: 2 additions & 0 deletions changelog.d/7768.misc
View file
Open in desktop
BillCarsonFr marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

Update matrix-analytics-events to version 0.15.0
BillCarsonFr marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ include:
packages:
AnalyticsEvents:
url: https://github.com/matrix-org/matrix-analytics-events
exactVersion: 0.5.0
exactVersion: 0.15.0
Mapbox:
url: https://github.com/maplibre/maplibre-gl-native-distribution
minVersion: 5.12.2
Expand Down
Loading