Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying the config location manually (outside of the user's profile) #1921

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

Half-Shot
Copy link
Member

The intention is for deployments in organizations where a machine may be shared, and the config is not local to a single user. The administrator can then place the common configuration file in a single location for each user to use.

Checklist

  • Ensure your code works with manual testing.
  • [N/A] New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • [N/A] I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@Half-Shot Half-Shot requested a review from a team as a code owner October 15, 2024 12:56
@t3chguy
Copy link
Member

t3chguy commented Oct 15, 2024

Related #731

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to find a way to test this? I'm really reluctant to add more stuff like this that will just break without us noticing.

@Half-Shot
Copy link
Member Author

Half-Shot commented Oct 15, 2024

I should be able to write a playwright test for this.

@Half-Shot Half-Shot self-assigned this Oct 15, 2024
@Half-Shot Half-Shot requested a review from dbkr October 17, 2024 08:48
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@dbkr dbkr merged commit 7b669a8 into develop Oct 17, 2024
32 checks passed
@dbkr dbkr deleted the hs/manually-specify-config-location branch October 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants