Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monochrome tray icon #1804

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

SakiiCode
Copy link
Contributor

This PR adds a white tray icon that would be important on Linux to better fit the other icons. It can be enabled/disabled with a checkbox item in the context menu. Uses the electron store to save user preference.

Resolves #757

Signed-off-by: Sakii <[email protected]>

Checklist

  • Ensure your code works with manual testing.
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@SakiiCode SakiiCode requested a review from a team as a code owner July 25, 2024 09:36
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 25, 2024
@t3chguy t3chguy requested a review from a team July 25, 2024 09:39
@t3chguy
Copy link
Member

t3chguy commented Jul 25, 2024

This needs design review and I think a UI preference flag rather than a context menu option

@richvdh richvdh removed their request for review July 30, 2024 17:25
@americanrefugee
Copy link

This needs design review and I think a UI preference flag rather than a context menu option

I need more info / context in order to review this... Are we just talking about showing a white/monochrome Element logo in the MacOS system bar at the top of the screen when in dark mode?

As for the logo itself, I think maybe @JordanConnor would be more knowledgeable about the intended appearance of the logo?

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2024

@americanrefugee I believe it is predominantly for Linux where it seems to be quite common for apps to have monochrome logos

@JordanConnor
Copy link

JordanConnor commented Aug 14, 2024

Is the icon displayed within a specific shape? We prefer to include the roundel in the icon were possible (svg example)

@t3chguy
Copy link
Member

t3chguy commented Aug 14, 2024

That'll depend on exactly what flavour of Linux you are running

@SakiiCode
Copy link
Contributor Author

SakiiCode commented Aug 14, 2024

I cannot attach screenshots to posts for some reason but you can find them here:
https://imgur.com/a/monochrome-element-screenshots-rkxoIZc

I think a UI preference flag rather than a context menu option

That may be the most fancy solution, however this is purely electron-related and involving element-web would make the implementation unnecessarily complex if it's even possible

@t3chguy
Copy link
Member

t3chguy commented Aug 14, 2024

@SakiiCode we already have other Electron-only prefs exposed in the UI preferences

image

@JordanConnor
Copy link

@SakiiCode, thanks for the screenshots, yes at that scale it does feel somewhat bulky. But for consistency we may still want the roundel included, like Steam does for example Screenshot 2024-08-14 at 14 42 19

@SakiiCode
Copy link
Contributor Author

Thanks for the feedback, I'll rework this PR

@SakiiCode SakiiCode marked this pull request as draft August 14, 2024 15:41
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

@SakiiCode SakiiCode marked this pull request as ready for review September 11, 2024 18:29
@SakiiCode
Copy link
Contributor Author

SakiiCode commented Sep 11, 2024

@t3chguy This PR should be ready but I can't seem to be able to create a PR for matrix-react-sdk. The UI preference option is in SakiiCode/matrix-react-sdk/trayicons (Somehow I forked the wrong repo sorry)

@florianduros
Copy link
Member

@JordanConnor Can you take a look at the new icons ? thanks!

@JordanConnor
Copy link

Icon LGTM!

@SakiiCode
Copy link
Contributor Author

@florianduros There was one thing I could not test: after getting pinged the red dot might(?) change back the icon to the colored one. Please definitely try this before merging

@florianduros
Copy link
Member

@SakiiCode Noted, thanks

Can you please sign the CLA in both PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for a monochrome tray icon to better fit in with other tray icons
6 participants