-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monochrome tray icon #1804
Add monochrome tray icon #1804
Conversation
This needs design review and I think a UI preference flag rather than a context menu option |
I need more info / context in order to review this... Are we just talking about showing a white/monochrome Element logo in the MacOS system bar at the top of the screen when in dark mode? As for the logo itself, I think maybe @JordanConnor would be more knowledgeable about the intended appearance of the logo? |
@americanrefugee I believe it is predominantly for Linux where it seems to be quite common for apps to have monochrome logos |
Is the icon displayed within a specific shape? We prefer to include the roundel in the icon were possible (svg example) |
That'll depend on exactly what flavour of Linux you are running |
I cannot attach screenshots to posts for some reason but you can find them here:
That may be the most fancy solution, however this is purely electron-related and involving element-web would make the implementation unnecessarily complex if it's even possible |
@SakiiCode we already have other Electron-only prefs exposed in the UI preferences |
@SakiiCode, thanks for the screenshots, yes at that scale it does feel somewhat bulky. But for consistency we may still want the roundel included, like Steam does for example |
Thanks for the feedback, I'll rework this PR |
062ef4a
to
2176750
Compare
@t3chguy This PR should be ready |
@JordanConnor Can you take a look at the new icons ? thanks! |
Icon LGTM! |
@florianduros There was one thing I could not test: after getting pinged the red dot might(?) change back the icon to the colored one. Please definitely try this before merging |
@SakiiCode Noted, thanks Can you please sign the CLA in both PR? |
This PR adds a white tray icon that would be important on Linux to better fit the other icons. It can be enabled/disabled with a checkbox item in the context menu. Uses the electron store to save user preference.
Resolves #757
Checklist
public
/exported
symbols have accurate TSDoc documentation.