#8885 Fix crash when joining a conference call on Android 14 (update jitsi-meet-sdk to 10.1.0) #8891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
I updated the jitsi-meet-sdk library version from 8.1.1 to 10.1.0.
IMPORTANT: The PR at element-hq/jitsi_libre_maven#1 needs to be merged first as it contains the new version of the library
mobile-sdk-10.1.0
.IMPORTANT # 2: I was unable build the project without adding mavenCentral() to the repo list. This is because the
react-native
binaries stopped being included with the Jitsi mobile SDK after version android-sdk-8.6.1. As a result, I needed to add thetransitive = true
flag to the dependency, and then themavenCentral(). I saw in the comments that we don't want to include
mavenCentral()`, but I was unable to figure out where to get it from if not maven central. I need guidance here on how to proceed before merging this PR.Motivation and context
This PR fixes the issue reported in #8885 . More specifically, when joining a conference call on Android 14, the Element app would crash.
Screenshots / GIFs
One important note is that it appears Conference calls no longer work on devices running below Android 6. As part of the testing outlined in the contributing guide, I tested on an Android emulator running SDK 22 (I could not find an emulator device that supported 21, so I went with 22). When joining a conference call, I received the following dialog:
In my opinion, this is an acceptable trade off because the number of people using Android 14 is much higher than the number of people using Android 5.1 (SDK 22) and below. The rest of Element still functions, just not the conference calls.
Tests
./gradlew testGplayReleaseUnitTest
Tested devices
Checklist
Signed-off-by: Christian Rowlands <craxiomdev [at] gmail.com>