Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8885 Fix crash when joining a conference call on Android 14 (update jitsi-meet-sdk to 10.1.0) #8891

Conversation

christianrowlands
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

I updated the jitsi-meet-sdk library version from 8.1.1 to 10.1.0.

IMPORTANT: The PR at element-hq/jitsi_libre_maven#1 needs to be merged first as it contains the new version of the library mobile-sdk-10.1.0.

IMPORTANT # 2: I was unable build the project without adding mavenCentral() to the repo list. This is because the react-native binaries stopped being included with the Jitsi mobile SDK after version android-sdk-8.6.1. As a result, I needed to add the transitive = true flag to the dependency, and then the mavenCentral(). I saw in the comments that we don't want to include mavenCentral()`, but I was unable to figure out where to get it from if not maven central. I need guidance here on how to proceed before merging this PR.

Motivation and context

This PR fixes the issue reported in #8885 . More specifically, when joining a conference call on Android 14, the Element app would crash.

Screenshots / GIFs

One important note is that it appears Conference calls no longer work on devices running below Android 6. As part of the testing outlined in the contributing guide, I tested on an Android emulator running SDK 22 (I could not find an emulator device that supported 21, so I went with 22). When joining a conference call, I received the following dialog:

image

In my opinion, this is an acceptable trade off because the number of people using Android 14 is much higher than the number of people using Android 5.1 (SDK 22) and below. The rest of Element still functions, just not the conference calls.

Tests

  • I ran this app on my Pixel 8 Pro that is running Android 14
  • I ran the tests ./gradlew testGplayReleaseUnitTest
  • I ran the app in an emulator for a Nexus 4 running SDK 22.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 14 Physical and Android 5.1 in the emulator.

Checklist

Signed-off-by: Christian Rowlands <craxiomdev [at] gmail.com>

@@ -72,6 +72,7 @@ allprojects {

repositories {
// Do not use `mavenCentral()`, it prevents Dependabot from working properly
// mavenCentral() // TODO Where to get com.facebook.react:react-android besides from mavenCentral?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmarty , What repo should I add to get the com.facebook.react:react-android dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you add to add the group com.facebook.react in the list here: https://github.com/element-hq/element-android/blob/develop/dependencies_groups.gradle#L58

Note: I am doing an upgrade to Jitsi 10.2.0 so maybe not useful to spend more time on this.

@christianrowlands
Copy link
Contributor Author

Bumping this PR @bmarty . I think I have it in a good place, except for where you want me to pull down the com.facebook.react:react-android dependency from.

@bmarty
Copy link
Member

bmarty commented Sep 18, 2024

Thanks for your work @christianrowlands

This PR is replaced by #8911.

@bmarty bmarty closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants