Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge Colors #71

Merged
merged 3 commits into from
May 10, 2024
Merged

Badge Colors #71

merged 3 commits into from
May 10, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented May 10, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner May 10, 2024 10:26
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team May 10, 2024 10:26
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (259b941) to head (1bc0413).

❗ Current head 1bc0413 differs from pull request most recent head bae46ab. Consider uploading reports for the commit bae46ab to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          18       18           
  Lines        1250     1253    +3     
=======================================
+ Hits         1209     1212    +3     
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Success instead of Highlighted. There's a system of success for green, info for blue and critical for red that we should follow here.

@Velin92
Copy link
Member Author

Velin92 commented May 10, 2024

Can we use Success instead of Highlighted. There's a system of success for green, info for blue and alert for red that we should follow here.

But not really a success is more like an highlighted or a positive connotation than a success thing which implies an action

@Velin92 Velin92 merged commit c1b9c32 into main May 10, 2024
1 check passed
@Velin92 Velin92 deleted the mauroromito/extra_colors branch May 10, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants