Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Prefire to a fork that fixes the configuration and templating,… #63

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

stefanceriu
Copy link
Member

… add multi-device snapshots

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (dce4984) to head (b9584b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   96.83%   96.78%   -0.05%     
==========================================
  Files          19       18       -1     
  Lines        1547     1524      -23     
==========================================
- Hits         1498     1475      -23     
  Misses         49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu marked this pull request as ready for review March 11, 2024 12:04
@stefanceriu stefanceriu requested a review from a team as a code owner March 11, 2024 12:04
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team March 11, 2024 12:04
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I haven't particularly looked at the stencil, I assume it's fine given the tests are happy.

Tests/CompoundTests/PreviewTests.stencil Outdated Show resolved Hide resolved
@stefanceriu
Copy link
Member Author

I haven't particularly looked at the stencil

Yeah, no worries, it's just the default one.

@stefanceriu stefanceriu merged commit 517311c into main Mar 11, 2024
2 checks passed
@stefanceriu stefanceriu deleted the stefan/prefireBump branch March 11, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants