Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of minor tweaks. #50

Merged
merged 1 commit into from
Nov 28, 2023
Merged

A couple of minor tweaks. #50

merged 1 commit into from
Nov 28, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 27, 2023

  • Fix the introspection of a text field in a list row (it was backed by a UITextView so was acting like a text editor by mistake)
  • Add the toggle accessibility trait on iOS 17.
  • Make the text field placeholder style reusable.

- Fix the introspection of a text field in a list row.
- Add the toggle accessibility trait on iOS 17.
- Make the text field placeholder style reusable.
@pixlwave pixlwave requested a review from a team as a code owner November 27, 2023 18:31
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 27, 2023 18:31
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sources/Compound/List/ListRow.swift Show resolved Hide resolved
@pixlwave pixlwave merged commit 8774e35 into main Nov 28, 2023
1 check passed
@pixlwave pixlwave deleted the doug/text-field branch November 28, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants