Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience initialisers for icons on ListRow. #46

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add convenience initialisers for icons on ListRow. #46

merged 1 commit into from
Nov 14, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 14, 2023 •
edited
Loading

Allows us to use

ListRow(label: .default(blah, icon: \.settings), …)

as a shortcut for

ListRow(label: .default(blah, icon: CompoundIcon(\.settings)), …)

@pixlwave pixlwave requested a review from a team as a code owner November 14, 2023 16:13
@pixlwave pixlwave requested review from nimau and removed request for a team November 14, 2023 16:13
@pixlwave pixlwave mentioned this pull request Nov 14, 2023
Merged
@pixlwave pixlwave merged commit 7ae8b7e into main Nov 14, 2023
1 check passed
@pixlwave pixlwave deleted the doug/list-icons branch November 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

@nimau nimau Awaiting requested review from nimau nimau is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @Velin92