Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the stroke colour of the secondary button style to match Figma. #110

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 10, 2024

Our secondary buttons weren't using the correct border colour, this PR fixes that.

Before After
old new

@pixlwave pixlwave requested a review from a team as a code owner October 10, 2024 09:53
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 10, 2024 09:53
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (94d93d0) to head (4485f3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   96.56%   96.58%   +0.01%     
==========================================
  Files          18       18              
  Lines        1165     1170       +5     
==========================================
+ Hits         1125     1130       +5     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 4535fa1 into main Oct 10, 2024
3 checks passed
@pixlwave pixlwave deleted the doug/secondary-button-border branch October 10, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants