Support for Xcode 16.0 (#106)

element-hq · Sep 19, 2024 · e93bec3 · e93bec3
1 parent 0d62484
commit e93bec3
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 7 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -20,12 +20,12 @@ jobs:
       with:
         submodules: recursive
 
-    - name: Configure Xcode 15
+    - name: Configure Xcode 16
       run: |
-        sudo xcode-select -s /Applications/Xcode_15.4.app
+        sudo xcode-select -s /Applications/Xcode_16_Release_Candidate.app
 
     - name: Run tests
-      run: xcodebuild test -scheme 'Compound' -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone SE (3rd generation),OS=17.5' -skipPackagePluginValidation -resultBundlePath Logs/CompoundTests.xcresult
+      run: xcodebuild test -scheme 'Compound' -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone SE (3rd generation),OS=18.0' -skipPackagePluginValidation -resultBundlePath Logs/CompoundTests.xcresult
 
     - name: Zip artifacts
       if: failure() # We only care about artefacts if the tests fail

diff --git a/Sources/Compound/List/ListRow.swift b/Sources/Compound/List/ListRow.swift
@@ -270,6 +270,8 @@ public struct ListRow_Previews: PreviewProvider, PrefireProvider {
             othersSection
         }
         .compoundList()
+        .frame(idealHeight: 2050) // Snapshot height
+        .previewLayout(.sizeThatFits)
     }
 
     static var labels: some View {

diff --git a/Sources/Compound/List/ListRowLabel.swift b/Sources/Compound/List/ListRowLabel.swift
@@ -378,5 +378,7 @@ struct ListRowLabel_Previews: PreviewProvider, PrefireProvider {
             }
         }
         .compoundList()
+        .frame(idealHeight: 1000) // Snapshot height
+        .previewLayout(.sizeThatFits)
     }
 }
diff --git a/Tests/CompoundTests/.prefire.yml b/Tests/CompoundTests/.prefire.yml
@@ -1,7 +1,7 @@
 test_configuration:
   - simulator_device: "iPhone14,6" # iPhone SE 3rd Generation
-  - required_os: 17
+  - required_os: 18
   - template_file_path: PreviewTests.stencil
   - snapshot_devices:
-    - iPhone 15
+    - iPhone 16
     - iPad
diff --git a/Tests/CompoundTests/PreviewTests.stencil b/Tests/CompoundTests/PreviewTests.stencil
@@ -162,7 +162,7 @@ class PreviewTests: XCTestCase {
 private extension PreviewDevice {
     func snapshotDevice() -> ViewImageConfig? {
         switch rawValue {
-        case "iPhone 15", "iPhone 14", "iPhone 13", "iPhone 12", "iPhone 11", "iPhone 10":
+        case "iPhone 16", "iPhone 15", "iPhone 14", "iPhone 13", "iPhone 12", "iPhone 11", "iPhone 10":
             return .iPhoneX
         case "iPhone 6", "iPhone 6s", "iPhone 7", "iPhone 8":
             return .iPhone8

diff --git a/Tests/CompoundTests/__Snapshots__ b/Tests/CompoundTests/__Snapshots__