Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change node-gyp to @electron/node-gyp #1157

Merged
merged 9 commits into from
Oct 8, 2024
Merged

feat: Change node-gyp to @electron/node-gyp #1157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
36c248b
fix: Change node-gyp to @electron/node-gyp
felixrieseberg Oct 7, 2024
2142382
fix: node-gyp has native promises now
felixrieseberg Oct 7, 2024
4599752
Move to a github version (temporarily)
felixrieseberg Oct 7, 2024
0f74e98
fix: Optional chaining
felixrieseberg Oct 7, 2024
900d428
test: Update the tests to ffi-napi
felixrieseberg Oct 7, 2024
63ac94e
fix: Use better-sqlite3 instead
felixrieseberg Oct 8, 2024
8a12916
test: Nevermind, go with a simple module
felixrieseberg Oct 8, 2024
1aa62c0
test: We're testing on one fewer module
felixrieseberg Oct 8, 2024
1517455
test: Use farmhash for clang testing
felixrieseberg Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@
"keywords": [
"electron"
],
"author": "Paul Betts <[email protected]>",
"authors": [
"Ani Betts <[email protected]>",
"Electron Community"
],
"license": "MIT",
"bugs": {
"url": "https://github.com/electron/rebuild/issues"
Expand All @@ -39,6 +42,7 @@
"node": ">=12.13.0"
},
"dependencies": {
"@electron/node-gyp": "^10.2.0-electron.1",
"@malept/cross-spawn-promise": "^2.0.0",
"chalk": "^4.0.0",
"debug": "^4.1.1",
Expand All @@ -47,7 +51,6 @@
"got": "^11.7.0",
"node-abi": "^3.45.0",
"node-api-version": "^0.2.0",
"node-gyp": "^9.0.0",
"ora": "^5.1.0",
"read-binary-file-arch": "^1.0.6",
"semver": "^7.3.5",
Expand Down
2 changes: 1 addition & 1 deletion src/module-type/node-gyp/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import NodeGypRunner from 'node-gyp';
import NodeGypRunner from '@electron/node-gyp';
import { promisify } from 'util';

process.on('message', async ({
Expand Down
2 changes: 1 addition & 1 deletion typings/ambient.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
declare module 'node-gyp';
declare module '@electron/node-gyp';
Loading