fix: Codesign issue when app name has spaces #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an issue: #237
I believe this was caused by not having the escape character when the codesign command string was being constructed; therefore, causing the codesign command to fail when codesigning the executable e.g.
App name.app/Contents/MacOS/App name
I was able to successfully codesign with electron-osx-sign with the change. I hope this resolves issues that others may have run into because their electron app product name has spaces.