Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: relative path for notarize file #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: relative path for notarize file #180

wants to merge 1 commit into from

Conversation

panther7
Copy link
Contributor

@panther7 panther7 commented Feb 25, 2024 •
edited
Loading

original issue: #153
original PR: #154
broken PR: #169 (thanks @DanielMcAssey )

This is fixed PR, thanks for ASAP merge (@MarshallOfSound)

@panther7 panther7 requested a review from a team as a code owner February 25, 2024 11:49
@DanielMcAssey
Copy link
Contributor

FYI, it's not really broken as appPath requires an absolute path as mentioned in the docs you updated

@panther7
Copy link
Contributor Author

Ok, but my (previous) PR fixing abs/rel paths.

Why this limitation (abs path), if is easy implement both paths?

MarshallOfSound
MarshallOfSound requested changes Feb 25, 2024
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring absolute paths is IMO a good thing, it removes ambiguity around the "relative to what" issue.

@panther7
Copy link
Contributor Author

But, this it works with absolute path ...and, if some want use relative path (and know about "relative to what" issue), now it will be posible.

erickzhao
erickzhao requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally a -1 on this as well because requiring an absolute path should be easy from a user perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao requested changes

@MarshallOfSound MarshallOfSound MarshallOfSound requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panther7 @DanielMcAssey @MarshallOfSound @erickzhao