Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip codesign check on pkg and dmg files #172

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jonluca
Copy link
Contributor

@jonluca jonluca commented Nov 22, 2023

Skip the codesign verification on pkg files because it does not need to be signed to be notarized. Fixes the issue introdocued in #152 (comment)

@jonluca jonluca requested a review from a team as a code owner November 22, 2023 02:26
@MarshallOfSound MarshallOfSound merged commit df2d00d into electron:main Feb 15, 2024
4 checks passed
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@panther7
Copy link
Contributor

Sign check works properly with dmg file.
Maybe, valid option will be some flag for check signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants