feat: add codesign verification and assessment prior to notarizing

src/check-signature.ts

@@ -0,0 +1,46 @@
+import * as path from 'path';
+
+import { spawn } from './spawn';
+import type { NotarizeStapleOptions } from './types';
+import debug from 'debug';
+const d = debug('electron-notarize');
+
+const codesignDisplay = async (opts: NotarizeStapleOptions) => {
+  const result = await spawn('codesign', ['-dv', '-vvvv', '--deep', path.basename(opts.appPath)], {
+    cwd: path.dirname(opts.appPath),
+  });
+  return result;
+};
+
+const codesign = async (opts: NotarizeStapleOptions) => {
+  d('attempting to check codesign of app:', opts.appPath);
+  const result = await spawn(
+    'codesign',
+    ['-vvv', '--deep', '--strict', path.basename(opts.appPath)],
+    {
+      cwd: path.dirname(opts.appPath),
+    },
+  );
+
+  return result;
+};
+export async function checkSignatures(opts: NotarizeStapleOptions): Promise<void> {
+  const codesignResult = await codesign(opts);
+  const codesignInfo = await codesignDisplay(opts);
+
+  let error = '';
+
+  if (codesignInfo.code !== 0) {
+    d('codesignInfo failed');
+    error = `Failed to display codesign info on your application with code: ${codesignInfo.code}\n\n${codesignInfo.output}\n`;
+  }
+  if (codesignResult.code !== 0) {
+    d('codesign check failed');
+    error += `Failed to codesign your application with code: ${codesignResult.code}\n\n${codesignResult.output}\n\n${codesignInfo.output}`;
+  }
+
+  if (error) {
+    throw new Error(error);
+  }
+  d('codesign assess succeeded');
+}

src/index.ts

@@ -6,6 +6,7 @@ import { startLegacyNotarize, waitForLegacyNotarize } from './legacy';
 import { isNotaryToolAvailable, notarizeAndWaitForNotaryTool } from './notarytool';
 import { stapleApp } from './staple';
 import { NotarizeOptions, NotaryToolStartOptions } from './types';
+import { checkSignatures } from './check-signature';
 
 const d = debug('electron-notarize');
 
@@ -14,6 +15,9 @@ export { NotarizeOptions };
 export { validateLegacyAuthorizationArgs as validateAuthorizationArgs } from './validate-args';
 
 export async function notarize({ appPath, ...otherOptions }: NotarizeOptions) {
+
+  await checkSignatures({ appPath });
+
   if (otherOptions.tool === 'legacy') {
     console.warn(
       'Notarizing using the legacy altool system. The altool system will be disabled on November 1 2023. Please switch to the notarytool system before then.',

src/spawn.ts

@@ -18,7 +18,7 @@ export const spawn = (
     'spawning cmd:',
     cmd,
     'args:',
-    args.map(arg => (isSecret(arg) ? '*********' : arg)),
+    args.map((arg) => (isSecret(arg) ? '*********' : arg)),
     'opts:',
     opts,
   );
@@ -28,10 +28,10 @@ export const spawn = (
   child.stdout!.on('data', dataHandler);
   child.stderr!.on('data', dataHandler);
   return new Promise<SpawnResult>((resolve, reject) => {
-    child.on('error', err => {
+    child.on('error', (err) => {
       reject(err);
     });
-    child.on('exit', code => {
+    child.on('exit', (code) => {
       d(`cmd ${cmd} terminated with code: ${code}`);
       resolve({
         code,