Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump @electron/rebuild to ^3.7.0 #3732

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

felixrieseberg
Copy link
Member

@felixrieseberg felixrieseberg commented Oct 8, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

This PR updates our version of @electron/rebuild. The biggest change here can be found in this PR: electron/rebuild#1157

Summarize your changes:

fix: Bump @electron/rebuild to ^3.7.0, which upgrades the internally used version of node-gyp to v10 - fixing, among other things, build errors on macOS Sequoia.

@felixrieseberg felixrieseberg requested a review from a team as a code owner October 8, 2024 18:15
@felixrieseberg felixrieseberg changed the title chore: Bump @electron/rebuild to ^3.7.0 fix: Bump @electron/rebuild to ^3.7.0 Oct 8, 2024
@felixrieseberg felixrieseberg added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit d6187ad Oct 8, 2024
15 checks passed
@felixrieseberg felixrieseberg deleted the felixr-bump-rebuild branch October 8, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants