Move @types/glob to devDependencies

[Hinton]

Type dependencies should be dev dependencies, that way they won't affect downstream packages.

This change seems to have no negative impacts on building or running tests in the project.

Resolves #330

[MarshallOfSound]

This is semantically incorrect and will also cause issues as we do use glob types in exported types

[Hinton]

@MarshallOfSound Would moving it back to an optional dependency work? Currently we have to delete both types/gulp and types/minimatch on postinstall.

[aaclayton]

This is causing big problems for us too. Our documentation builds (typedoc) are completely failing because of this unless we do clumsy manual workarounds.

Isn't glob now natively in typescript anyways? Why is an extra types package needed?

[erikian]

Isn't glob now natively in typescript anyways? Why is an extra types package needed?

It is, but at this moment @electron/asar supports Node 10.12.0 and up, while glob only became native TS on v9 which requires Node 16. We do have plans to upgrade all ecosystem packages to a newer Node version as soon as support for requireing ESM graphs makes it into Node LTS, but I'm afraid we probably won't be updating glob until then unless we need to land another breaking change in the meantime.

That being said, based on #267 / #268, looks like we've solved this in the past by inlining the types, and that got lost when @electron/asar was rewritten in TS in #320, so we can probably just re-land the changes from #268 – I'll open a PR for that in a minute.

[erikian]

Fixed in #336