Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling meteor client for offline use. #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JarnoLeConte
Copy link

@JarnoLeConte JarnoLeConte commented May 22, 2016

My first attempt to use meteor-electron to build offline apps.

This will bundle meteor client code with the app. So instead of an external entry point rootUrl it will now have a single local entry file index.html (together with a .js and .css file) that serves the whole app. The packaged app is therefore self contained.

It relies on the package meteor-build-client which I have modified to run as node module. Originally it was a CLI only. Although that package needs some improvements. Error handling is not done very well, and there is little control over the executed commands which could lead to ghost processes. But I guess this could be improved over time.

All you have to do is include "bundleClient": true in the electron settings.

@rwatts3
Copy link

rwatts3 commented May 25, 2016

This looks great any word on when it will be merged ?

@johnking
Copy link

I like this feature very much! And looking forward to seeing it merged!

@JarnoLeConte
Copy link
Author

Until it's merged you can use my atmosphere package jarnoleconte:electron instead of meson:electron.

It would be great if people can test it. I'm not sure of the bundling method work well on all platforms.

@jmarks-joshua
Copy link

jmarks-joshua commented Sep 30, 2016

Hi this seems like a great idea, it's totally what i need for my next project... but I'm getting an error when i try to use the atmosphere package.

originally when i ran it i got a bunch of access issues so i ran it with sudo, but still getting that one permission denied issue.

gyp ERR! clean error
gyp ERR! stack Error: EACCES: permission denied, rmdir 'build'
gyp ERR! stack at Error (native)
gyp ERR! System Darwin 15.6.0
gyp ERR! command
gyp ERR! node -v v4.5.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok

npm ERR! Darwin 15.6.0
npm ERR! argv
npm ERR! node v4.5.0
npm ERR! npm v3.10.6
npm ERR! code ELIFECYCLE
npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nslog package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild

it says i should attach the log, but the log isn't where it says it is so I don't think i can.

I tried again today... works totally fine no idea what was different, but seems all good so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants