Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartyView - List winning constituency candidates #178

Merged
merged 3 commits into from
Mar 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 96 additions & 62 deletions src/components/PerPartyMemberVoteResult.js
Original file line number Diff line number Diff line change
@@ -1,42 +1,12 @@
import React, { useState } from "react"
import { DESKTOP_MIN_WIDTH, media, DISPLAY_FONT } from "../styles"
import { numberWithCommas } from "../util/format"
import { useSummaryData } from "../models/LiveDataSubscription"
import { partyStatsFromSummaryJSON } from "../models/PartyStats"

const mockData = [
{
name: "นายประมูล อึ้งไปเลยสิย้ง",
zone: "ราชบุรี, เขต 3",
vote: "1234567",
percentage: "20",
},
{
name: "นายย้ง อึ้งไปเลยสิประมูล",
zone: "ราชบุรี, เขต 3",
vote: "672367",
percentage: "20",
},
{
name: "นายอึ้ง ย้ง",
zone: "ราชบุรี, เขต 3",
vote: "345",
percentage: "20",
},
{
name: "นายย้ง อึ้ง",
zone: "ราชบุรี, เขต 3",
vote: "22344",
percentage: "20",
},
]

const defaultTab = "EACH_DISTRICT_TAB"

// @todo #1 Party View - binding data to ZonePartyMemberVoteResult
export default function ZonePartyMemberVoteResult({
data = mockData,
totalDistrictCandidate = 31,
totalPartyListCandidate = 13,
}) {
const defaultTab = "DISTRICT_TAB"

export default function ZonePartyMemberVoteResult({ partyId }) {
const [state, setState] = useState({
showingTab: defaultTab,
})
Expand All @@ -55,6 +25,23 @@ export default function ZonePartyMemberVoteResult({
const eachDistrictStyling =
state.showingTab === defaultTab ? { ...active } : {}
const partyListStyling = state.showingTab !== defaultTab ? { ...active } : {}

/** @type {ElectionDataSource.SummaryJSON} */
const summaryState = useSummaryData()
const winningConstituencyCandidates = getWinningConstituencyCandidates(
summaryState,
partyId
)
const winningPartyListCandidates = getWinningPartyListCandidates(
summaryState,
partyId
)

const visibleCandidatesList =
state.showingTab === defaultTab
? winningConstituencyCandidates
: winningPartyListCandidates

return (
<div
css={{
Expand Down Expand Up @@ -84,48 +71,95 @@ export default function ZonePartyMemberVoteResult({
<li
css={{ ...tabHeaderStyle, ...eachDistrictStyling }}
onClick={() => {
// @todo #1 Party View - result panel - implement showing candidate's vote result when select tab

setState({ showingTab: defaultTab })
}}
>
แบ่งเขต({totalDistrictCandidate})
แบ่งเขต({winningConstituencyCandidates.length})
</li>
<li
css={{ ...tabHeaderStyle, ...partyListStyling }}
onClick={() => {
setState({ showingTab: "PARTY_LIST_TAB" })
}}
>
บัญชีรายชื่อ ({totalPartyListCandidate})
บัญชีรายชื่อ ({winningPartyListCandidates.length})
</li>
</ul>
</div>

{/* list */}
<div css={{ textAlign: "left", padding: "5px" }}>
{data.map(item => (
<div
css={{ display: "flex", position: "relative", marginTop: "15px" }}
>
<img
src={require(`../styles/images/pmcan/1-s.png`)}
css={{ width: "30px", height: "30px", borderRadius: "50%" }}
/>
<div css={{ marginLeft: "5px", fontFamily: DISPLAY_FONT }}>
<div css={{ fontWeight: "bold" }}>{item.name}</div>
<div css={{ fontSize: "0.8em" }}>{item.zone}</div>
</div>
<div css={{ float: "right", position: "absolute", right: 0 }}>
<span css={{ fontWeight: "bold" }}>
{numberWithCommas(item.vote)}
</span>{" "}
- {item.percentage}%
</div>
</div>
))}
</div>
<CandidatesList candidates={visibleCandidatesList} />
</div>
</div>
)
}

function CandidatesList({ candidates }) {
if (candidates.length > 0) {
return (
<div css={{ textAlign: "left", padding: "5px" }}>
{candidates.map(item => (
<div
css={{ display: "flex", position: "relative", marginTop: "15px" }}
>
<div css={{ marginLeft: "5px", fontFamily: DISPLAY_FONT }}>
<div css={{ fontWeight: "bold" }}>
{item.firstName} {item.lastName}
</div>
<div css={{ fontSize: "0.8em" }}>{item.zone}</div>
</div>
<div css={{ float: "right", position: "absolute", right: 0 }}>
<span css={{ fontWeight: "bold" }}>
{numberWithCommas(item.score)}
</span>{" "}
- {Math.round(item.percentage * 100)}%
</div>
</div>
))}
</div>
)
} else {
return <p>ไม่พบข้อมูล</p>
}
}

function getWinningConstituencyCandidates(summaryState, partyId) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getWinningConstituencyCandidates has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getWinningConstituencyCandidates has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

if (!summaryState.completed) {
return []
} else {
const summary = summaryState.data
let winningCandidates = []

// For each provinceId...
for (const provinceId of Object.keys(summary.zoneWinningCandidateMap)) {
const zoneNoWinningCandidateMap =
summary.zoneWinningCandidateMap[provinceId]

// For each zone number...
for (const zoneNo of Object.keys(zoneNoWinningCandidateMap)) {
const candidateData = zoneNoWinningCandidateMap[zoneNo]
const votesTotal = summary.zoneStatsMap[provinceId][zoneNo].votesTotal

// Add to list only if the candidate matches the partyId
if (candidateData.partyId == partyId) {
candidateData["percentage"] = candidateData.score / votesTotal || 0
winningCandidates.push(candidateData)
}
}
}

return winningCandidates
}
}

function getWinningPartyListCandidates(summaryState) {
if (!summaryState.completed) {
return []
} else {
const summary = summaryState.data
const partyStats = partyStatsFromSummaryJSON(summary)

// @todo #1 Party View - display winning party-list candidates

return []
}
}
6 changes: 3 additions & 3 deletions src/components/PerPartyView.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function PerPartyView({ partyId }) {
>
<PerPartySearchPanelContainer partyId={partyId} />
<PerPartyMapView partyId={partyId} />
<ZoneStats />
<ZoneStats partyId={partyId} />
</div>
</div>
)
Expand Down Expand Up @@ -62,6 +62,6 @@ function PerPartyMapView({ partyId }) {
)
}

function ZoneStats() {
return <PerPartyMemberVoteResult />
function ZoneStats({ partyId }) {
return <PerPartyMemberVoteResult partyId={partyId} />
}