Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script patch #1994 #2029

Closed
wants to merge 9 commits into from

Conversation

iaacornus
Copy link

@iaacornus iaacornus commented Apr 23, 2024

Description

fixed #1994 which raised an error due to (pep 668)[https://peps.python.org/pep-0668/], however, instead of using the --break-system-packages flag to override the error, i thikn using pipx is a better solution.

there are other minor improvements made, but not biggy

Issue Fixes

#1994

Checklist:

  • [] I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

just run the script into ubuntu or other distro, should work, havent tested it tho

Copy link
Collaborator

@JasonLovesDoggo JasonLovesDoggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if i'm wrong but pipx install does not have a -r arg.

@iaacornus
Copy link
Author

Correct me if i'm wrong but pipx install does not have a -r arg.

i've addressed it in the lastest commit

@github-actions github-actions bot added the stale label May 2, 2024
@Cyteon
Copy link
Collaborator

Cyteon commented May 10, 2024

On Arch:

Installing...
Continue? (y/n)
y
Installing all
Installing required packages
warning: python-3.12.3-1 is up to date -- skipping
warning: python-pipx-1.5.0-2 is up to date -- skipping
warning: tk-8.6.14-3 is up to date -- skipping
warning: git-2.45.0-1 is up to date -- skipping
there is nothing to do
usage: python -m ensurepip [-h] [--version] [-v] [-U] [--user] [--root ROOT] [--altinstall] [--default-pip]
python -m ensurepip: error: unrecognized arguments: unzip
Installation failed

@github-actions github-actions bot removed the stale label May 11, 2024
@iaacornus
Copy link
Author

On Arch:

Installing...
Continue? (y/n)
y
Installing all
Installing required packages
warning: python-3.12.3-1 is up to date -- skipping
warning: python-pipx-1.5.0-2 is up to date -- skipping
warning: tk-8.6.14-3 is up to date -- skipping
warning: git-2.45.0-1 is up to date -- skipping
there is nothing to do
usage: python -m ensurepip [-h] [--version] [-v] [-U] [--user] [--root ROOT] [--altinstall] [--default-pip]
python -m ensurepip: error: unrecognized arguments: unzip
Installation failed

this appears to be an error due to fault in arch's dep install function, latest commit fixed it. idk why the previous author tried to put unzip as an argument to python3 -m ensurepip, should be in sudo pacman -S. should work now.

@Cyteon Cyteon added the enhancement New feature or request label May 13, 2024
install.sh Outdated Show resolved Hide resolved
DEP_LIST=./RedditVideoMakerBot-master/requirements.txt
if [[ -f $DEP_LIST ]]; then
while read -r DEPS; do
pipx install $DEPS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested on other distros, but on arch at least, pipx install packagename prints out an error for most packages:

No apps associated with package packagename. Try again with '--include-deps' to include apps of dependent
packages, which are listed above. If you are attempting to install a library, pipx should not be used.
Consider using pip or a similar tool instead.

@github-actions github-actions bot added the stale label May 21, 2024
@github-actions github-actions bot closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Experimental Bug] Linux/Mac Installer script did not install correctly.
3 participants