Handle Websocket using standard library #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccording to RFC6455
|
@elazarl do you want to give me a review about this PR? |
|
@ErikPelli will look into it, I have to re-read the websocket RFC to really verify that. |
|
Sure! Take your time |
|
@elazarl have you had any chance to look at this PR? Can I merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630.
Instead of relying on custom code to handshake WebSockets separately, just rely on the standard library response Body, as explained in the documentation.
This will also use a cascadeproxy configuration by default, without the need to setting a custom per-request Dialer, when the custom transport is configured with a proxy URL.
I also update the websocket example to use a more updated WebSocket client library.