Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove http.* settings #16552

Merged
merged 12 commits into from
Oct 18, 2024
Merged

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Oct 14, 2024

Release notes

Removed the deprecated settings http.port, http.host, http.enabled, and http.environment. Please use api.http.port, api.http.host, api.http.enabled, and api.http.environment instead.

What does this PR do?

The commit removes the deprecated settings http.port, http.host, http.enabled, and http.environment.

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • run bin/logstash -e "input { stdin {} } output { stdout {} }" --http.enabled false gives "ERROR: Unrecognised option '--http.enabled'"

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@jsvd
Copy link
Member

jsvd commented Oct 17, 2024

Seems like there are still a few references to http.port:

❯ grep "http\.host" . -r | grep -v api
./docker/data/logstash/config/logstash-oss.yml:http.host: "0.0.0.0"
./docker/data/logstash/config/logstash-full.yml:http.host: "0.0.0.0"
./docs/static/docker.asciidoc:`http.host`:: `0.0.0.0`

@kaisecheng
Copy link
Contributor Author

@jsvd good catch!

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@kaisecheng kaisecheng requested a review from jsvd October 17, 2024 23:34
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisecheng kaisecheng merged commit 566bdf6 into elastic:main Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants