Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tychon, ti_custom: fix system tests for 9.0 #12549

Merged

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Fix system tests for 9.0.0 in Tychon and Custom TI packages.

Added mapping for log.file.fingerprint in Custom TI integration.

The filestream input has changed file identity determination from native to
fingerprint, and the default fingerprint minimum file size is 1kiB, so make
all test inputs at least this big in Tychon integration.

Same approach as taken in #12510.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Run system tests as follows:

elastic-package stack down && elastic-package stack up -v -d --version=9.0.0-SNAPSHOT && eval "$(elastic-package stack shellinit)"

Then in each of the affected package directories:

elastic-package test system

Related issues

@chemamartinez chemamartinez added enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:tychon TYCHON Agentless Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Integration:Custom TI labels Jan 31, 2025
@chemamartinez chemamartinez self-assigned this Jan 31, 2025
@chemamartinez chemamartinez marked this pull request as ready for review January 31, 2025 09:30
@chemamartinez chemamartinez requested a review from a team as a code owner January 31, 2025 09:30
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chemamartinez chemamartinez changed the title 9.0.0 system tests ti custom tychon tychon, ti_custom: fix system tests for 9.0 Jan 31, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chemamartinez

@andrewkroh andrewkroh added Integration:ti_custom Custom Threat Intelligence and removed Integration:Custom TI labels Jan 31, 2025
@chemamartinez chemamartinez merged commit 97476d7 into elastic:main Feb 3, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package ti_custom - 0.7.0 containing this change is available at https://epr.elastic.co/package/ti_custom/0.7.0/

harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 4, 2025
Fix system tests for Custom TI and Tychon for 9.0
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
Fix system tests for Custom TI and Tychon for 9.0
harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 5, 2025
Fix system tests for Custom TI and Tychon for 9.0
@chemamartinez chemamartinez deleted the 9.0.0-system-tests-ti_custom-tychon branch February 6, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:ti_custom Custom Threat Intelligence Integration:tychon TYCHON Agentless Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
4 participants