Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fortinet Fortigate] swap source and destination for fortigate VPN event #11523

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Fortinet Fortigate] swap source and destination for fortigate VPN event #11523

wants to merge 4 commits into from
+89 −70

Conversation

gogochan
Copy link
Contributor

Proposed commit message

#9394

This PR fixes VPN events Fortinet Fortigate.

For VPN events, source is the client and the destination is the firewall, therefore the field must be swapped to represent the traffic flow.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gogochan gogochan added the bug Something isn't working, use only for issues label Oct 25, 2024
@gogochan gogochan requested a review from a team as a code owner October 25, 2024 16:44
@gogochan gogochan added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Oct 25, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

taylor-swanson
taylor-swanson reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine to me, but perhaps this should be a "minor" version change, since it changes what values we're storing where.

1.25.9 -> 1.26.0

@gogochan
Copy link
Contributor Author

Change looks fine to me, but perhaps this should be a "minor" version change, since it changes what values we're storing where.

1.25.9 -> 1.26.0

Done ecfb39b

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gogochan @elasticmachine @taylor-swanson