Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Mark secret variables !! #11507

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Synthetics] Mark secret variables !! #11507

wants to merge 3 commits into from
+22 −1

Conversation

shahzad31
Copy link
Contributor

@andrewkroh andrewkroh added the Integration:synthetics Elastic Synthetics label Oct 24, 2024
@shahzad31 shahzad31 marked this pull request as ready for review October 24, 2024 10:37
@shahzad31 shahzad31 requested a review from a team as a code owner October 24, 2024 10:37
emilioalvap
emilioalvap approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh added the Team:obs-ux-infra_services Label for the Obs UX: Infra & Services team [elastic/obs-ux-infra_services-team] label Oct 24, 2024
@elasticmachine
Copy link

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@andrewkroh andrewkroh added the enhancement New feature or request label Oct 24, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh left review comments

@emilioalvap emilioalvap emilioalvap approved these changes

@dominiqueclarke dominiqueclarke Awaiting requested review from dominiqueclarke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request Integration:synthetics Elastic Synthetics Team:obs-ux-infra_services Label for the Obs UX: Infra & Services team [elastic/obs-ux-infra_services-team]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @andrewkroh @emilioalvap