Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure_metrics] Enable subobjects: false on azure.resource.tags.* #11345

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −8
Draft

[azure_metrics] Enable subobjects: false on azure.resource.tags.* #11345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c82d324
Enable subobjects: false on azure.resource.tags.*
zmoog Oct 7, 2024
36dd77d
Update tests adding field with dots in the name
zmoog Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...zure_metrics/data_stream/compute_vm/_dev/test/pipeline/test-azure-metrics-compute-vm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@
"group": "obs-infrastructure",
"tags": {
"vmtest1": "value3",
"vmtest": "value1, value 2"
"vmtest": "value1, value 2",
"i.contain.dots": "value4"
}
},
"namespace": "Microsoft.Compute/virtualMachines",
Expand Down
3 changes: 2 additions & 1 deletion ...ata_stream/compute_vm/_dev/test/pipeline/test-azure-metrics-compute-vm.json-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"name": "obstestmemleak",
"tags": {
"vmtest": "value1, value 2",
"vmtest1": "value3"
"vmtest1": "value3",
"i.contain.dots": "value4"
},
"type": "Microsoft.Compute/virtualMachines"
},
Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/compute_vm/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down
6 changes: 5 additions & 1 deletion ...stream/compute_vm_scaleset/_dev/test/pipeline/test-azure-metrics-compute-vm-scaleset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@
"name": "obswinvmss",
"id": "/subscriptions/70bd6e77-4b1e-4835-8896-db77b8eef364/resourceGroups/obs-infrastructure/providers/Microsoft.Compute/virtualMachineScaleSets/obswinvmss",
"type": "Microsoft.Compute/virtualMachineScaleSets",
"group": "obs-infrastructure"
"group": "obs-infrastructure",
"tags": {
"vmtest1": "value1",
"i.contain.dots": "value2"
}
},
"namespace": "Microsoft.Compute/virtualMachineScaleSets"
}
Expand Down
6 changes: 5 additions & 1 deletion ..._vm_scaleset/_dev/test/pipeline/test-azure-metrics-compute-vm-scaleset.json-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
"group": "obs-infrastructure",
"id": "/subscriptions/70bd6e77-4b1e-4835-8896-db77b8eef364/resourceGroups/obs-infrastructure/providers/Microsoft.Compute/virtualMachineScaleSets/obswinvmss",
"name": "obswinvmss",
"type": "Microsoft.Compute/virtualMachineScaleSets"
"type": "Microsoft.Compute/virtualMachineScaleSets",
"tags": {
"vmtest1": "value1",
"i.contain.dots": "value2"
}
},
"subscription_id": "70bd6e77-4b1e-4835-8896-db77b8eef364",
"timegrain": "PT5M"
Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/compute_vm_scaleset/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down
3 changes: 2 additions & 1 deletion ...a_stream/container_instance/_dev/test/pipeline/test-azure-metrics-container-instance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
"id": "/subscriptions/70bd6e77-4b1e-4835-8896-db77b8eef364/resourceGroups/obs-infrastructure/providers/Microsoft.ContainerInstance/containerGroups/testcontainergroup",
"type": "Microsoft.ContainerInstance/containerGroups",
"tags": {
"tag1": "value1"
"tag1": "value1",
"i.contain.dots": "value2"
},
"group": "obs-infrastructure"
},
Expand Down
3 changes: 2 additions & 1 deletion ...iner_instance/_dev/test/pipeline/test-azure-metrics-container-instance.json-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"id": "/subscriptions/70bd6e77-4b1e-4835-8896-db77b8eef364/resourceGroups/obs-infrastructure/providers/Microsoft.ContainerInstance/containerGroups/testcontainergroup",
"name": "testcontainergroup",
"tags": {
"tag1": "value1"
"tag1": "value1",
"i.contain.dots": "value2"
},
"type": "Microsoft.ContainerInstance/containerGroups"
},
Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/container_registry/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down
3 changes: 2 additions & 1 deletion ...etrics/data_stream/container_service/_dev/test/pipeline/test-azure-container-service.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"type": "Microsoft.ContainerService/managedClusters",
"group": "test_group",
"tags": {
"custodian_status": "Resource does not meet policy: delete@2023/09/26"
"custodian_status": "Resource does not meet policy: delete@2023/09/26",
"i.contain.dots": "value2"
}
},
"namespace": "Microsoft.ContainerService/managedClusters",
Expand Down
3 changes: 2 additions & 1 deletion ...ream/container_service/_dev/test/pipeline/test-azure-container-service.json-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"id": "/subscriptions/a2960656-390f-47b5-a154-b048d34ab096/resourceGroups/test_group/providers/Microsoft.ContainerService/managedClusters/test",
"name": "test",
"tags": {
"custodian_status": "Resource does not meet policy: delete@2023/09/26"
"custodian_status": "Resource does not meet policy: delete@2023/09/26",
"i.contain.dots": "value2"
},
"type": "Microsoft.ContainerService/managedClusters"
},
Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/container_service/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/database_account/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/monitor/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down
1 change: 1 addition & 0 deletions packages/azure_metrics/data_stream/storage_account/fields/package-fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
type: object
object_type: keyword
object_type_mapping_type: "*"
subobjects: false
description: >
Azure resource tags.

Expand Down