Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample to use updatecli to update mysql image #10652

Closed
wants to merge 1 commit into from

Conversation

jsoriano
Copy link
Member

Try to use updatecli to automatically update mysql variant image.

Related to elastic/elastic-package#1902.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Member Author

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmsr added a couple of comments highlighting the parts that would be more relevant to manage each version upgrade. The rest is mostly boilerplate.

Comment on lines +40 to +44
- name: Update mysql services.
# --experimental needed for commitusingapi option.
run: updatecli --experimental ${{ env.UPDATECLI_ACTION }} --config .github/workflows/updatecli-packages.d/mysql.yml --values .github/workflows/updatecli.d/scm.yml
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following this approach, an entry like this one would be needed for any service. We could try to find some way to run all the configs at once.

Comment on lines +26 to +42
sources:
latest:
kind: dockerimage
spec:
image: mysql
architecture: "linux/amd64"
kind: latest
tagfilter: '^8.\d*.\d*$'

targets:
mysqlTag:
name: "mysql variant"
kind: file
spec:
file: "packages/mysql/_dev/deploy/variants.yml"
matchpattern: '(IMAGE: mysql:)8.*'
replacepattern: '${1}{{ source "latest" }}'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This source and target would be the main part to configure for every version to upgrade.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@andrewkroh andrewkroh added Integration:mysql MySQL Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Aug 2, 2024
@botelastic
Copy link

botelastic bot commented Sep 1, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 1, 2024
@botelastic
Copy link

botelastic bot commented Oct 1, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:mysql MySQL Stalled Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants