[Visual Refresh] Support new theme tokens on JSON exports #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonStoltz
reviewed
Jan 15, 2025
packages/eui/src-docs/src/views/theme/_json/eui_theme_amsterdam_light.json
Outdated
Show resolved
Hide resolved
JasonStoltz
requested changes
Jan 15, 2025
|
Preview staging links for this PR:
|
💔 Build Failed
Failed CI StepsHistory
cc @mgadewoll |
JasonStoltz
approved these changes
Jan 20, 2025
acstll
added a commit
to acstll/kibana
that referenced
this pull request
Jan 28, 2025
acstll
added a commit
to elastic/kibana
that referenced
this pull request
Jan 30, 2025
`99.0.0-borealis.1` ⏩ `99.1.0-borealis.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- # `@elastic/eui` ## [`v99.1.0`](https://github.com/elastic/eui/releases/v99.1.0) - Updated `EuiColorPalettePicker` - adds `append` to `EuiColorPalettePickerPaletteProps` to support appending custom content to the title ([#8208](elastic/eui#8208)) - Updated font-weight and font-size of `EuiBetaBadge`s to improve legibility ([#8255](elastic/eui#8255)) - Added suppport for `titleColor` variant `warning` on `EuiStat` ([#8278](elastic/eui#8278)) # `@elastic/eui-theme-borealis` ## `v0.0.9` - [Visual Refresh] Support new theme tokens on JSON exports ([#8277](elastic/eui#8277)) - Remap few colors for EuiLoadingSpinner and EuiLoadingChart ([#8276](elastic/eui#8276)) - [Visual Refresh] Update floating border on EuiPanel ([#8270](elastic/eui#8270)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: nickofthyme <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch.
This PR introduces support for the new theme tokens that were added on
euiThemeas well as SCSS variables already.Initially our plan was to deprecate JSON token usage completely, which made the support for new tokens unnecessary.
But during the theme migration we noticed that there are use cases on Kibana where we can't remove the JSON token usage just yet and where the new tokens are required to support the new theme.
Note
Updating JSON tokens is currently still a manual process.
Changes
accentSecondaryequivalents in AmsterdamQA
I'm afraid there is no nice way to QA this besides manual checks as those tokens are not in use 🙈
But I'm confident the update is correct as the update was done as follows:
euiTheme.colorsoutput per theme and color mode and added relevant tokens to the JSON file (ensures correct color values)euiColorprefixes