Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding github assistant code #340

Merged
merged 14 commits into from
Oct 21, 2024
Merged

Adding github assistant code #340

merged 14 commits into from
Oct 21, 2024

Conversation

framsouza
Copy link
Contributor

@framsouza framsouza self-assigned this Oct 14, 2024
@xeraa xeraa requested a review from a team October 16, 2024 17:07
carlyrichmond
carlyrichmond requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@carlyrichmond carlyrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, LGTM. Can you add a small readme with an overview and any prerequisites needed to run the code? While most readers will come here from your blog, it's useful to have a README just in case people come across the labs code first.

@carlyrichmond carlyrichmond merged commit 60cc76e into main Oct 21, 2024
2 checks passed
@carlyrichmond carlyrichmond deleted the github-assistant branch October 21, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlyrichmond carlyrichmond carlyrichmond approved these changes

Assignees

@framsouza framsouza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@framsouza @carlyrichmond