fixing comments by code review

elastic · Oct 22, 2024 · b3ff9ba · b3ff9ba
1 parent fb99c98
commit b3ff9ba
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 12 deletions.
diff --git a/...orting-blog-content/hybrid-search-for-an-e-commerce-product-catalogue/README.md b/...orting-blog-content/hybrid-search-for-an-e-commerce-product-catalogue/README.md
@@ -15,7 +15,7 @@ This project consists of two main components: a front-end application and an API
 
 ### API
 
-- Developed with python
+- Developed with Python
 - Provides endpoints for fetching product data and handling search/filter requests.
 - Implements hybrid search combining lexical and semantic search techniques.
 

diff --git a/...t/hybrid-search-for-an-e-commerce-product-catalogue/app-product-store/README.md b/...t/hybrid-search-for-an-e-commerce-product-catalogue/app-product-store/README.md
@@ -26,6 +26,7 @@ semantic search techniques, offering more accurate and relevant results.
 2. Navigate to the project directory:
    ```bash
    cd repository-name
+   
 3. Install dependencies:
    ```bash
    npm install

diff --git a/...og-content/hybrid-search-for-an-e-commerce-product-catalogue/app-product-store/src/App.js b/...og-content/hybrid-search-for-an-e-commerce-product-catalogue/app-product-store/src/App.js
@@ -93,7 +93,6 @@ const ProductCard = ({ product, searchTerm, products }) => {
   const defaultImage = "https://via.placeholder.com/100";
 
   const handleClick = () => {
-    //alert(`Produto: ${product.name} - Termo de pesquisa: ${searchTerm}`);
 
     trackSearchClick({
       document: { id: product.id, index: "products-catalog"},
@@ -179,7 +178,7 @@ const ProductPage = () => {
           query: searchTerm,
           selectedCategories: selectedFacets.categories,
           selectedProductTypes: selectedFacets.productTypes,
-          selectedbrands: selectedFacets.brands,
+          selectedBrands: selectedFacets.brands,
           hybrid: isHybridSearch
         }
       });
@@ -212,7 +211,7 @@ const ProductPage = () => {
           query: searchTerm,
           selectedCategories: selectedFacets.categories,
           selectedProductTypes: selectedFacets.productTypes,
-          selectedbrands: selectedFacets.brands,
+          selectedBrands: selectedFacets.brands,
           hybrid: isHybridSearch
         }
       });

diff --git a/...ybrid-search-for-an-e-commerce-product-catalogue/product-store-search/README.md b/...ybrid-search-for-an-e-commerce-product-catalogue/product-store-search/README.md
@@ -88,8 +88,8 @@ applying filters to refine the results according to specific criteria.
 
 ---
 
-## Referências
+## References
 
-- [Documentação do Docker](https://docs.docker.com/)
-- [Documentação do Docker Compose](https://docs.docker.com/compose/)
+- [Docker Documentation](https://docs.docker.com/)
+- [Docker Compose Documentation](https://docs.docker.com/compose/)
 
diff --git a/...content/hybrid-search-for-an-e-commerce-product-catalogue/product-store-search/api/api.py b/...content/hybrid-search-for-an-e-commerce-product-catalogue/product-store-search/api/api.py
@@ -53,14 +53,14 @@ def build_query(term=None, categories=None, product_types=None, brands=None):
 
 
 def build_hybrid_query(term=None, categories=None, product_types=None, brands=None, hybrid=False):
-    # Query padrão
+    # Standard query
     organic_query = build_query(term, categories, product_types, brands)
 
     if hybrid is True and term:
 
         vector = get_text_vector([term])[0]
 
-        # Query híbrida com RRF (Reciprocal Rank Fusion)
+        # Hybrid query with RRF (Reciprocal Rank Fusion)
         query = {
             "retriever": {
                 "rrf": {
@@ -174,7 +174,7 @@ def search():
     query = request.args.get('query')
     categories = request.args.getlist('selectedCategories[]')
     product_types = request.args.getlist('selectedProductTypes[]')
-    brands = request.args.getlist('selectedbrands[]')
+    brands = request.args.getlist('selectedBrands[]')
     hybrid = request.args.get('hybrid', 'False').lower() == 'true'
     results = search_products(query, categories=categories, product_types=product_types,
                               brands=brands,
@@ -188,7 +188,7 @@ def facets():
     query = request.args.get('query')
     categories = request.args.getlist('selectedCategories[]')
     product_types = request.args.getlist('selectedProductTypes[]')
-    brands = request.args.getlist('selectedbrands[]')
+    brands = request.args.getlist('selectedBrands[]')
     results = get_facets_data(query, categories=categories,
                               product_types=product_types,
                               brands=brands)

diff --git a/...id-search-for-an-e-commerce-product-catalogue/product-store-search/ingestion/ingestion.py b/...id-search-for-an-e-commerce-product-catalogue/product-store-search/ingestion/ingestion.py
@@ -52,5 +52,4 @@ def index_data_in_batches(file_path, index_name, batch_size=100):
 
 
 if __name__ == '__main__':
-    # print(get_client_es().info())
     index_data_in_batches("../files/dataset/products.json", "products-catalog", batch_size=100)