try a test matrix with two ES stacks

elastic · Feb 1, 2024 · 71df597 · 71df597
1 parent fceeda0
commit 71df597
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -12,10 +12,15 @@ on:
       - notebooks/**
 jobs:
   notebook-tests:
+    strategy:
+      matrix:
+        es_stack:
+          - 8.11.4
+          - 8.12.0
     runs-on: ubuntu-latest
     services:
       elasticsearch:
-        image: docker.elastic.co/elasticsearch/elasticsearch:8.12.0
+        image: docker.elastic.co/elasticsearch/elasticsearch:${{ matrix.es_stack }}
         env:
           discovery.type: single-node
           xpack.security.enabled: false

diff --git a/bin/find-notebooks-to-test.sh b/bin/find-notebooks-to-test.sh
@@ -2,6 +2,7 @@
 # add any notebooks that are currently not testable to the exempt list
 EXEMPT_NOTEBOOKS=(
     "notebooks/search/07-inference.ipynb"
+    "notebooks/search/08-learning-to-rank.ipynb"
     "notebooks/langchain/langchain-vector-store.ipynb"
     "notebooks/langchain/self-query-retriever-examples/chatbot-example.ipynb"
     "notebooks/langchain/self-query-retriever-examples/chatbot-with-bm25-only-example.ipynb"