Run integration tests in CI #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test helpers were removed in elasticsearch-py 8 anyway, and this will help re-enabling integration tests in CI.
JoshMock
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests were skipped in CI because
WAIT_FOR_ESwas forgotten in the move from Travis to GitHub Actions. While I was here, I introduced a few changes, one per commit:elasticsearch.helpers.testssince it was removed from elasticsearch-py 8.x and certificates are not needed here. (But this will be ultimately removed in favor of more pytest-native code, like elasticsearch-py did.)nowaittowaitbecause I find parameters with a negative name very confusing (we hadnowait=Falseandnowait="WAIT_FOR_ES" not in os.environ!).WAIT_FOR_ESis set but the connection fails.