-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-sdk-java to 1.10.11 #234
Conversation
See also elastic/elasticsearch#12859 |
Any idea how long it will take for a change like that to go through review and possible make it back to ES 1.5 (or 1.7 at least)? |
For now I'm reopening your PR for this repo in case we plan to fix it for 1.7 and previous versions. |
Thanks, I appreciate it. Considering this happened using the official ElasticSearch repository in DockerHub and was sparked by them making a modification to all of their base images as far as I can tell (in this case the java:8 repo), I would imagine there will be many others having this problem soon if they aren't already. |
Follow up for #234. Release notes: http://aws.amazon.com/releasenotes/Java/6635368276326731 Closes #236. (cherry picked from commit 51d70f2)
Follow up for #234. Release notes: http://aws.amazon.com/releasenotes/Java/6635368276326731 Closes #236. (cherry picked from commit 51d70f2) (cherry picked from commit bc56248)
Follow up for #234. Release notes: http://aws.amazon.com/releasenotes/Java/6635368276326731 Closes #236.
Anyone is up to run a test on a test cluster ? bin/plugin install cloud-aws --url https://oss.sonatype.org/content/repositories/snapshots/org/elasticsearch/elasticsearch-cloud-aws/2.7.1-SNAPSHOT/elasticsearch-cloud-aws-2.7.1-20150824.122206-1.zip The goal is to run elasticsearch 1.7 with this 2.7.1-SNAPSHOT version using either Java 1.7.0_85 or 1.8u60 (or >) If you guys tries it, could you report here? Thanks a lot for your help! |
I still have the same issue with the 2-7.1-SNAPSHOT cloud-aws plugin, running elasticsearch 1.7.1, Oracle java 1.8u60
|
@pvanderlinden can you tell me what you have in elasticsearch Thanks! Also, how did you install your JVM? I mean, download from oracle? |
@dadoonet The ls -l:
|
@pvanderlinden Everything looks correct to me. I guess that you restarted the node, right? I heard recently on a similar issue with openJDK 1.7.0.85. It worked well when using redhead/centos openJDK 1.7.0.85 build 2.6.1.3.el6_6 but not when using openJDK 1.7.0.85 build 2.6.1.3.el6_7 Any chance here you have a similar issue? |
@dadoonet I restarted the node indeed. Not sure what your question is? What I had before I upgraded: Oracle Java 1.8u45 with cloud-aws on version 2.5.0, that still works fine in an old test instance. On an other test instance I completely removed java, and all downloaded packages for java, reinstalled, but it is still failing with the same error. |
Did you run at some point ES 1.5 + CloudAWS 2.5.0 but with Latest Java Oracle version on the same machine? I'm trying to understand where the issue is coming from. JVM? Cloud plugin? AWS SDK? ... |
@dadoonet I tried a couple of things on a test machine and other installations |
Sorry you wrote:
And then
You meant you did not try ES 1.5 with 1.8u60, right? Whatever, I saw this comment today: aws/aws-sdk-java#444 (comment) Might be the same concern... Will investigate more. |
I meant that I didn't try ES 1.5 with 1.8u60 indeed. |
Ok I know what is wrong. I'll update the SNAPSHOT and report again here. Thanks for your help so far! |
Could you try: bin/plugin install cloud-aws --url https://oss.sonatype.org/content/repositories/snapshots/org/elasticsearch/elasticsearch-cloud-aws/2.7.1-SNAPSHOT/elasticsearch-cloud-aws-2.7.1-20150826.180934-2.zip Thanks! |
The new snapshot works fine, create, restore and list snapshot all works again, Thanks. |
\o/ Thanks again for your help! I really appreciate. Planning to release soonish now. |
Follow up for discussion #234 We need to pull in Joda 2.8.2 and don't rely of the version declared by elasticsearch which is currently 2.7. It will fix issues seen with recent Java versions. See also aws/aws-sdk-java#444 Closes #239. (cherry picked from commit 0db449a)
Follow up for discussion #234 We need to pull in Joda 2.8.2 and don't rely of the version declared by elasticsearch which is currently 2.7. It will fix issues seen with recent Java versions. See also aws/aws-sdk-java#444 Closes #239.
Thanks for fixing. This should fix my last problem with the ELK stack hopefully. |
Will there be a release 2.7.1 with this fix anytime soon? |
@pliljenberg Definitely yes! Very very soon! |
@pliljenberg @pvanderlinden @lusid 2.7.1 and 2.6.1 have been released. |
@dadoonet, any chance of getting 2.7.1 into the maven repository? As best as I can see, only 2.7.0 is available. Thanks! |
@dbaggott weird! Sounds like it was partially released. Indeed, artifacts are not in maven repo. |
@dadoonet, thank you! |
ps you probably already noted this but all of the fixed versions are missing: 2.4.3, 2.5.2, etc |
No I didn't. Need to fix that. |
@dbaggott I looked at it.
I just pushed the last 2 versions. It will need some minutes I guess to be synchronized on maven central. Thanks again for raising that! |
Fantastic, thank you. I can confirm that both 2.7.1 and 2.6.1 are now available (despite not showing up in the UI yet). |
Has this fix been backported to ES 1.5? |
No. You should update to elasticsearch 1.7 and update AWS plugin accordingly. |
I meant it has been backported but this branch has not been released since. |
Follow up for elastic#234. Release notes: http://aws.amazon.com/releasenotes/Java/6635368276326731 Closes elastic#236. (cherry picked from commit 51d70f2) (cherry picked from commit bc56248) (cherry picked from commit 9781068) (cherry picked from commit a6d7787)
@smiller171
It worked for me doing this. But I only have to do this for a local environment running Java 8 I have (since we're running Java 7 where our actual cluster is) so I don't think I'd really recommending downloading a snapshot and changing out jars in the plugin directory. It'd probably be a little safer to replace the other AWS jars as well, but like I said, I didn't because on my local environment I didn't need to test any of the other features of the cloud-aws plugin Sorry for resurrecting an old thread after the solution for people running 1.5 is to migrate to a different version was given by the maintainer! |
Fixes #233
Amazon SDK v1.9.34 S3 functionality used by elasticsearch-cloud-aws no longer works after OpenJDK v1.8u60 due to JodaTime issues with timezone. More information here: aws/aws-sdk-java#444