Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tlscommon] Add test helper methods #269

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

khushijain21
Copy link
Contributor

What does this PR do?

This PR moves some helper methods for testing in a test_helper.go file to be able to reuse these methods publicly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@khushijain21 khushijain21 requested a review from a team as a code owner January 28, 2025 15:18
@khushijain21 khushijain21 requested review from belimawr and VihasMakwana and removed request for a team January 28, 2025 15:18
@mauri870
Copy link
Member

I confirmed that the functions are now properly exported.

$ go doc ./transport/tlscommon | grep 'GetCertFingerprint\|GenTestCerts'
func GenTestCerts(t *testing.T) map[string]*x509.Certificate
func GetCertFingerprint(cert *x509.Certificate) string

@khushijain21
Copy link
Contributor Author

/test

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@khushijain21 khushijain21 merged commit e8b8e7b into elastic:main Jan 29, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants