Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardcoded qualifier #3162

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

navarone-feekery
Copy link
Contributor

@navarone-feekery navarone-feekery commented Jan 30, 2025

Add hard-coded qualifier beta1 so nightly builds have a qualifier. This will be removed when we release 9.0.

@navarone-feekery navarone-feekery marked this pull request as ready for review January 30, 2025 15:29
@navarone-feekery navarone-feekery requested a review from a team as a code owner January 30, 2025 15:29
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We run nightlies for recent branches, would that also affect them?

@navarone-feekery
Copy link
Contributor Author

navarone-feekery commented Jan 30, 2025

@artem-shelkovnikov the nightlies should be unaffected because we produce both snapshots and staging DRAs, according to @seanstory:

Nightlies are snapshots AND staging DRAs.
Yes, that change would work. I was thinking putting it in the pipeline.yml, but this is totally fine.
Snapshots are exempt from qualifiers.
Relevant logic block:

if [[ "${BUILDKITE_BRANCH:-}" =~ (main|8\.x|[0-9]\.[0-9x]*$) ]]; then
export PUBLISH_SNAPSHOT="true"
fi
if [[ "${BUILDKITE_BRANCH:-}" =~ ([0-9]\.[0-9x]*$) ]]; then
export PUBLISH_STAGING="true"
fi
if [ -n "${VERSION_QUALIFIER:-}" ]; then
# this is a special case where we will release a pre-release artifact, regardless of branch
export PUBLISH_STAGING="true"
fi

init_dra_publishing.sh
So after we cut a 9.0 branch, the nightlies will start producing staging and snapshot builds for 9.0.0. Right now, they're only snapshot, because main isn't on the staging branch pattern, and is only included if you specify a qualifier. (edited)

@navarone-feekery
Copy link
Contributor Author

We run nightlies for recent branches, would that also affect them?

Or do you mean branches that aren't main?
If we don't backport it should be fine, right?

@seanstory
Copy link
Member

correct, as long as we dont' backport, it's fine

@seanstory seanstory merged commit a819ce4 into main Jan 30, 2025
3 checks passed
@seanstory seanstory deleted the navarone/add-hardcoded-beta1-qualifier branch January 30, 2025 20:10
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3162 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants