Revert Changes to Connectors CLI Config Loading and Use Separate Configuration for Stack Scripts #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrewdson
approved these changes
Jan 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
…iguration for Stack Scripts (#2048)
markjhoy
added a commit
that referenced
this pull request
Jan 10, 2024
…te Configuration for Stack Scripts (#2048) (#2050) Co-authored-by: Mark J. Hoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to: #1947
Reverts the changes to the
connectors_cli.pyconfiguration loading in favour of the original method. Updates the scripts to use a separate configuration for the CLI used in the Connectors configuration script to connect to the Elasticsearch instance.Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)