-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PostgreSQL] Remove duplicate PK check in advanced sync rules #2007
Merged
artem-shelkovnikov
merged 4 commits into
main
from
timgrein/remove-duplicate-pk-check-postgresql
Dec 22, 2023
Merged
[PostgreSQL] Remove duplicate PK check in advanced sync rules #2007
artem-shelkovnikov
merged 4 commits into
main
from
timgrein/remove-duplicate-pk-check-postgresql
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildkite test this |
1 similar comment
buildkite test this |
@timgrein updating the branch from main should fix ftests for you |
artem-shelkovnikov
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a test for it too?
artem-shelkovnikov
deleted the
timgrein/remove-duplicate-pk-check-postgresql
branch
December 22, 2023 14:20
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
Co-authored-by: Artem Shelkovnikov <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
Co-authored-by: Artem Shelkovnikov <[email protected]>
artem-shelkovnikov
added a commit
that referenced
this pull request
Dec 22, 2023
…2007) (#2015) Co-authored-by: Tim Grein <[email protected]> Co-authored-by: Artem Shelkovnikov <[email protected]>
artem-shelkovnikov
added a commit
that referenced
this pull request
Dec 22, 2023
…2007) (#2014) Co-authored-by: Tim Grein <[email protected]> Co-authored-by: Artem Shelkovnikov <[email protected]>
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2002
Removes the duplicate primary keys check in advanced sync rules for the PostgreSQL connector to enable JOINs, also when the primary keys of different tables are the same.
Checklists
Pre-Review Checklist
v7.13.2
,v7.14.0
,v8.0.0
)