Ignore errors when Sink or Extractor is forcibly canceled #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._logger.warning( | ||
| f"Sink did not stop within {CANCELATION_TIMEOUT} seconds of cancelation, force-canceling the task." | ||
| ) | ||
| return |
There was a problem hiding this comment.
I think you need to re-raise here, if error is not ForceCancelledError or self._canceled
artem-shelkovnikov
approved these changes
Dec 19, 2023
wangch079
deleted the
chenhui/ignore-error-if-sink-extractor-is-forcibly-canceled
branch
wangch079
added a commit
that referenced
this pull request
Dec 19, 2023
…) (#1996) Co-authored-by: Chenhui Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1985
What's the change
warningwhen a sync job is forcibly canceledSinkorExtractorclass if theSinkorExtractorobject is forcibly canceledWhy the change
In the last release, we Forcibly cancel a sync job after waiting for 5 seconds. This should not be treated as
ERROR, therefore we want to log it atwarninglevel.When we forcibly cancel the
SinkorExtractortask, it will throw aForceCanceledError. But sometimes there can be other errors thrown due to task cancellation, and be caught first. Before we log those errors ascritical, we want to check if the task is forcibly canceled. If so, we will ignore those errors, and instead log awarningmessage that the task is forcibly canceled.Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)