Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectors API] Add postman collection #1954

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

timgrein
Copy link
Contributor

@timgrein timgrein commented Dec 6, 2023

Closes https://github.com/elastic/enterprise-search-team/issues/6375

This PR adds the postman collection for the Connectors API, which can be used for manual testing during development. It contains all happy paths requests and also edge cases to verify validation, parsing etc.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

jedrazb
jedrazb previously approved these changes Dec 6, 2023
Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀


You need to specify values for the following variables:

- `ES_HOST_PORT`: Specifies the host and port of your Elasticsearch instance you want to test against (example: `http://localhost:9200`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/Do we have it set to default value of localhost:9200 or is it empty by default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see

"variable": [
		{
			"key": "ES_HOST_PORT",
			"value": "localhost:9200"
		}
	]
}

👍

Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the ES_PASSWORD and ES_USER don't have default value? I don't see them listed as a variables under "variable": [ ...]?

@timgrein timgrein merged commit ef65b83 into main Dec 6, 2023
@timgrein timgrein deleted the timgrein/connectors-api-postman-collection branch December 6, 2023 16:05
Copy link

github-actions bot commented Dec 6, 2023

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 1954 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants