Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPO] Adding OData__UIVersionString document version field #1884

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

llermaly
Copy link
Contributor

@llermaly llermaly commented Nov 9, 2023

This PR adds the OData__UIVersionString to the documents. This field is useful to filter out drafts using sync rules.

When this option enabled:

image

Files can have versions.

0.1 means unpublished draft
After published becomes 1.0
Then I save a new draft and becomes 1.1

image

Sync rule to exclude drafts (everything that doesn't end with 0): ^(?!.*\.0$).*$

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference

@llermaly llermaly requested review from seanstory, ppf2 and a team November 9, 2023 03:56
Copy link

cla-checker-service bot commented Nov 9, 2023

💚 CLA has been signed

@llermaly llermaly changed the title Adding OData__UIVersionString document version field [SPO] Adding OData__UIVersionString document version field Nov 9, 2023
@seanstory
Copy link
Member

@llermaly can you sign the Contributor License Agreement? #1884 (comment)

Then this should be good to merge.

@llermaly
Copy link
Contributor Author

@seanstory signed!

@seanstory seanstory force-pushed the gustavo/spo-add-version-field branch from 6144902 to d100bd0 Compare November 15, 2023 22:30
@seanstory
Copy link
Member

@llermaly I've rebased in such a way that I'm now seen as the only committer so that the CLA check passes.

@seanstory seanstory enabled auto-merge (squash) November 15, 2023 22:31
@seanstory
Copy link
Member

seanstory commented Nov 15, 2023

@elastic/ingestion-team can I get an approval? I rebased myself, so my approval doesn't count anymore 🙈

EDIT: or not... I feel like that shouldn't have worked?

Copy link

💚 Backport PR(s) successfully created

Status Branch Result
pre-8.10-stable #1903
8.11 #1904
8.10 #1905

The backport PRs will be merged automatically after passing CI.

seanstory added a commit that referenced this pull request Nov 16, 2023
seanstory added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants