Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #2938) [Asset Inventory][Azure] Add storage asset fetchers #2961

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 29, 2025

Summary of your changes

Introduces fetchers for:

  • Azure Storage Table Service
  • Azure Storage File Service
  • Azure Storage Table
  • Azure Storage File Share
  • Azure Storage Blob Container

Screenshot/Data

Screenshot 2025-01-22 at 15 08 33 Screenshot 2025-01-22 at 15 08 19 Screenshot 2025-01-22 at 13 27 03 Screenshot 2025-01-22 at 12 56 46 Screenshot 2025-01-22 at 12 27 56 Screenshot 2025-01-21 at 10 59 25 Screenshot 2025-01-21 at 10 59 15

Related Issues

Closes https://github.com/elastic/security-team/issues/10172

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

This is an automatic backport of pull request #2938 done by [Mergify](https://mergify.com).

(cherry picked from commit 57ecd03)

# Conflicts:
#	internal/inventory/ASSETS.md
#	internal/inventory/asset.go
#	internal/inventory/cloud_assets.xlsx
#	tests/product/tests/data/azure_asset_inventory/test_cases.py
#	tests/product/tests/test_aws_asset_inventory.py
#	tests/product/tests/test_azure_asset_inventory.py
#	tests/product/tests/test_gcp_asset_inventory.py
@mergify mergify bot added the backport label Jan 29, 2025
@mergify mergify bot requested a review from a team as a code owner January 29, 2025 13:41
@mergify mergify bot added the conflicts label Jan 29, 2025
Copy link
Author

mergify bot commented Jan 29, 2025

Cherry-pick of 57ecd03 has failed:

On branch mergify/bp/8.x/pr-2938
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 57ecd035.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   internal/inventory/azurefetcher/fetcher_storage.go
	modified:   internal/inventory/azurefetcher/fetcher_storage_test.go
	modified:   internal/inventory/azurefetcher/mock_storage_provider.go
	modified:   internal/resources/providers/azurelib/inventory/asset.go
	modified:   internal/resources/providers/azurelib/inventory/mock_storage_account_provider_api.go
	modified:   internal/resources/providers/azurelib/inventory/storage_provider.go
	modified:   internal/resources/providers/azurelib/inventory/storage_provider_test.go
	modified:   internal/resources/providers/azurelib/mock_provider_api.go
	modified:   tests/pyproject.toml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   internal/inventory/ASSETS.md
	both modified:   internal/inventory/asset.go
	both modified:   internal/inventory/cloud_assets.xlsx
	both modified:   tests/product/tests/data/azure_asset_inventory/test_cases.py
	both modified:   tests/product/tests/test_aws_asset_inventory.py
	deleted by us:   tests/product/tests/test_azure_asset_inventory.py
	both modified:   tests/product/tests/test_gcp_asset_inventory.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@kubasobon
Copy link
Member

kubasobon commented Jan 29, 2025

Decided against backporting it to 8.x. Closing.

@kubasobon kubasobon closed this Jan 29, 2025
@kubasobon kubasobon deleted the mergify/bp/8.x/pr-2938 branch January 29, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant