Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS Azure 3.5, 3.13, 3.14 #1764

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Jan 3, 2024

Summary of your changes

  • 3.5 Ensure Storage Logging is Enabled for Queue Service for 'Read', 'Write', and 'Delete' requests
  • 3.13 Ensure Storage logging is Enabled for Blob Service for 'Read', 'Write', and 'Delete' requests
  • 3.14 Ensure Storage Logging is Enabled for Table Service for 'Read', 'Write', and 'Delete' Requests

Screenshot/Data

Screenshot 2024-01-04 at 1 20 00 PM

Related Issues

Fixes: #1416

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Copy link

mergify bot commented Jan 3, 2024

This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Jan 3, 2024
@moukoublen moukoublen force-pushed the cis_azure_3.5_3.13_3.14 branch 2 times, most recently from 4e6a014 to e83d6f6 Compare January 3, 2024 22:55
@moukoublen moukoublen marked this pull request as ready for review January 4, 2024 08:47
@moukoublen moukoublen requested a review from a team as a code owner January 4, 2024 08:47
@moukoublen moukoublen force-pushed the cis_azure_3.5_3.13_3.14 branch from 92593f0 to 8220d74 Compare January 4, 2024 08:47
@romulets romulets self-requested a review January 4, 2024 08:53
@moukoublen moukoublen force-pushed the cis_azure_3.5_3.13_3.14 branch from 8220d74 to 3044690 Compare January 4, 2024 09:22
@moukoublen moukoublen requested a review from romulets January 4, 2024 11:43
Copy link
Member

@romulets romulets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about error handling, but overall it looks good

@moukoublen moukoublen force-pushed the cis_azure_3.5_3.13_3.14 branch from cad367b to 4d27b86 Compare January 4, 2024 13:03
Copy link

mergify bot commented Jan 4, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cis_azure_3.5_3.13_3.14 upstream/cis_azure_3.5_3.13_3.14
git merge upstream/main
git push upstream cis_azure_3.5_3.13_3.14

@moukoublen moukoublen force-pushed the cis_azure_3.5_3.13_3.14 branch from 4d27b86 to 02bddce Compare January 4, 2024 14:24
@moukoublen moukoublen merged commit 82ec0cd into elastic:main Jan 4, 2024
17 of 18 checks passed
@moukoublen moukoublen deleted the cis_azure_3.5_3.13_3.14 branch January 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CIS Azure] Storage Accounts rules
2 participants