Refactor asset inventory (#2879)

(cherry picked from commit cbadcb7)

# Conflicts:
#	internal/inventory/awsfetcher/fetcher_lambda.go
#	tests/product/tests/data/aws_asset_inventory/test_cases.py
#	tests/product/tests/test_azure_asset_inventory.py

internal/inventory/awsfetcher/fetcher_ec2_instance.go

@@ -58,66 +58,46 @@ func (e *ec2InstanceFetcher) Fetch(ctx context.Context, assetChannel chan<- inve
 		return
 	}
 
-	for _, instance := range instances {
-		if instance == nil {
+	for _, i := range instances {
+		if i == nil {
 			continue
 		}
 
 		iamFetcher := inventory.EmptyEnricher()
-		if instance.IamInstanceProfile != nil {
-			iamFetcher = inventory.WithIAM(inventory.AssetIAM{
-				Id:  instance.IamInstanceProfile.Id,
-				Arn: instance.IamInstanceProfile.Arn,
+		if i.IamInstanceProfile != nil {
+			iamFetcher = inventory.WithUser(inventory.User{
+				ID: pointers.Deref(i.IamInstanceProfile.Arn),
 			})
 		}
 
-		subnetIds := []string{}
-		if id := pointers.Deref(instance.SubnetId); id != "" {
-			subnetIds = append(subnetIds, id)
-		}
 		assetChannel <- inventory.NewAssetEvent(
 			inventory.AssetClassificationAwsEc2Instance,
-			[]string{instance.GetResourceArn(), pointers.Deref(instance.InstanceId)},
-			instance.GetResourceName(),
+			i.GetResourceArn(),
+			pointers.Deref(i.PrivateDnsName),
 
-			inventory.WithRawAsset(instance),
-			inventory.WithTags(e.getTags(instance)),
-			inventory.WithCloud(inventory.AssetCloud{
+			inventory.WithRelatedAssetIds([]string{pointers.Deref(i.InstanceId)}),
+			inventory.WithRawAsset(i),
+			inventory.WithLabels(e.getTags(i)),
+			inventory.WithCloud(inventory.Cloud{
 				Provider:         inventory.AwsCloudProvider,
-				Region:           instance.Region,
-				AvailabilityZone: e.getAvailabilityZone(instance),
-				Account: inventory.AssetCloudAccount{
-					Id:   e.AccountId,
-					Name: e.AccountName,
-				},
-				Instance: &inventory.AssetCloudInstance{
-					Id:   pointers.Deref(instance.InstanceId),
-					Name: instance.GetResourceName(),
-				},
-				Machine: &inventory.AssetCloudMachine{
-					MachineType: string(instance.InstanceType),
-				},
-				Service: &inventory.AssetCloudService{
-					Name: "AWS EC2",
-				},
+				Region:           i.Region,
+				AvailabilityZone: e.getAvailabilityZone(i),
+				AccountID:        e.AccountId,
+				AccountName:      e.AccountName,
+				InstanceID:       pointers.Deref(i.InstanceId),
+				InstanceName:     i.GetResourceName(),
+				MachineType:      string(i.InstanceType),
+				ServiceName:      "AWS EC2",
 			}),
-			inventory.WithHost(inventory.AssetHost{
-				Architecture:    string(instance.Architecture),
-				ImageId:         instance.ImageId,
-				InstanceType:    string(instance.InstanceType),
-				Platform:        string(instance.Platform),
-				PlatformDetails: instance.PlatformDetails,
+			inventory.WithHost(inventory.Host{
+				ID:           pointers.Deref(i.InstanceId),
+				Name:         pointers.Deref(i.PrivateDnsName),
+				Architecture: string(i.Architecture),
+				Type:         string(i.InstanceType),
+				IP:           pointers.Deref(i.PublicIpAddress),
+				MacAddress:   i.GetResourceMacAddresses(),
 			}),
 			iamFetcher,
-			inventory.WithNetwork(inventory.AssetNetwork{
-				NetworkId:        instance.VpcId,
-				SubnetIds:        subnetIds,
-				Ipv6Address:      instance.Ipv6Address,
-				PublicIpAddress:  instance.PublicIpAddress,
-				PrivateIpAddress: instance.PrivateIpAddress,
-				PublicDnsName:    instance.PublicDnsName,
-				PrivateDnsName:   instance.PrivateDnsName,
-			}),
 		)
 	}
 }
@@ -134,10 +114,10 @@ func (e *ec2InstanceFetcher) getTags(instance *ec2.Ec2Instance) map[string]strin
 	return tags
 }
 
-func (e *ec2InstanceFetcher) getAvailabilityZone(instance *ec2.Ec2Instance) *string {
+func (e *ec2InstanceFetcher) getAvailabilityZone(instance *ec2.Ec2Instance) string {
 	if instance.Placement == nil {
-		return nil
+		return ""
 	}
 
-	return instance.Placement.AvailabilityZone
+	return pointers.Deref(instance.Placement.AvailabilityZone)
 }

internal/inventory/awsfetcher/fetcher_ec2_instance_test.go

@@ -64,6 +64,14 @@ func TestEC2InstanceFetcher_Fetch(t *testing.T) {
 			Placement: &types.Placement{
 				AvailabilityZone: pointers.Ref("1a"),
 			},
+			NetworkInterfaces: []types.InstanceNetworkInterface{
+				{
+					MacAddress: pointers.Ref("mac1"),
+				},
+				{
+					MacAddress: pointers.Ref("mac2"),
+				},
+			},
 		},
 		Region: "us-east",
 	}
@@ -78,77 +86,55 @@ func TestEC2InstanceFetcher_Fetch(t *testing.T) {
 	expected := []inventory.AssetEvent{
 		inventory.NewAssetEvent(
 			inventory.AssetClassificationAwsEc2Instance,
-			[]string{"arn:aws:ec2:us-east::ec2/234567890", "234567890"},
-			"test-server",
+			"arn:aws:ec2:us-east::ec2/234567890",
+			"private-dns",
+			inventory.WithRelatedAssetIds([]string{"234567890"}),
 			inventory.WithRawAsset(instance1),
-			inventory.WithTags(map[string]string{"Name": "test-server", "key": "value"}),
-			inventory.WithCloud(inventory.AssetCloud{
+			inventory.WithLabels(map[string]string{"Name": "test-server", "key": "value"}),
+			inventory.WithCloud(inventory.Cloud{
 				Provider:         inventory.AwsCloudProvider,
 				Region:           "us-east",
-				AvailabilityZone: pointers.Ref("1a"),
-				Account: inventory.AssetCloudAccount{
-					Id:   "123",
-					Name: "alias",
-				},
-				Instance: &inventory.AssetCloudInstance{
-					Id:   "234567890",
-					Name: "test-server",
-				},
-				Machine: &inventory.AssetCloudMachine{
-					MachineType: "instance-type",
-				},
-				Service: &inventory.AssetCloudService{
-					Name: "AWS EC2",
-				},
+				AvailabilityZone: "1a",
+				AccountID:        "123",
+				AccountName:      "alias",
+				InstanceID:       "234567890",
+				InstanceName:     "test-server",
+				MachineType:      "instance-type",
+				ServiceName:      "AWS EC2",
 			}),
-			inventory.WithHost(inventory.AssetHost{
-				Architecture:    string(types.ArchitectureValuesX8664),
-				ImageId:         pointers.Ref("image-id"),
-				InstanceType:    "instance-type",
-				Platform:        "linux",
-				PlatformDetails: pointers.Ref("ubuntu"),
+			inventory.WithHost(inventory.Host{
+				ID:           "234567890",
+				Name:         "private-dns",
+				Architecture: string(types.ArchitectureValuesX8664),
+				Type:         "instance-type",
+				IP:           "public-ip-addr",
+				MacAddress:   []string{"mac1", "mac2"},
 			}),
-			inventory.WithIAM(inventory.AssetIAM{
-				Id:  pointers.Ref("a123123"),
-				Arn: pointers.Ref("123123:123123:123123"),
-			}),
-			inventory.WithNetwork(inventory.AssetNetwork{
-				NetworkId:        pointers.Ref("vpc-id"),
-				SubnetIds:        []string{"subnetId"},
-				Ipv6Address:      pointers.Ref("ipv6"),
-				PublicIpAddress:  pointers.Ref("public-ip-addr"),
-				PrivateIpAddress: pointers.Ref("private-ip-addre"),
-				PublicDnsName:    pointers.Ref("public-dns"),
-				PrivateDnsName:   pointers.Ref("private-dns"),
+			inventory.WithUser(inventory.User{
+				ID: "123123:123123:123123",
 			}),
 		),
 
 		inventory.NewAssetEvent(
 			inventory.AssetClassificationAwsEc2Instance,
-			[]string{},
+			"",
 			"",
 			inventory.WithRawAsset(instance2),
-			inventory.WithTags(map[string]string{}),
-			inventory.WithCloud(inventory.AssetCloud{
-				Provider: inventory.AwsCloudProvider,
-				Region:   "us-east",
-				Account: inventory.AssetCloudAccount{
-					Id:   "123",
-					Name: "alias",
-				},
-				Instance: &inventory.AssetCloudInstance{
-					Id:   "",
-					Name: "",
-				},
-				Machine: &inventory.AssetCloudMachine{
-					MachineType: "",
-				},
-				Service: &inventory.AssetCloudService{
-					Name: "AWS EC2",
-				},
+			inventory.WithLabels(map[string]string{}),
+			inventory.WithCloud(inventory.Cloud{
+				Provider:         inventory.AwsCloudProvider,
+				Region:           "us-east",
+				AvailabilityZone: "",
+				AccountID:        "123",
+				AccountName:      "alias",
+				InstanceID:       "",
+				InstanceName:     "",
+				MachineType:      "",
+				ServiceName:      "AWS EC2",
+			}),
+			inventory.WithHost(inventory.Host{
+				MacAddress: []string{},
 			}),
-			inventory.WithHost(inventory.AssetHost{}),
-			inventory.WithNetwork(inventory.AssetNetwork{SubnetIds: []string{}}),
 		),
 	}
 

internal/inventory/awsfetcher/fetcher_elb.go

@@ -81,19 +81,15 @@ func (f *elbFetcher) fetch(ctx context.Context, resourceName string, function el
 	for _, item := range awsResources {
 		assetChannel <- inventory.NewAssetEvent(
 			classification,
-			[]string{item.GetResourceArn()},
+			item.GetResourceArn(),
 			item.GetResourceName(),
 			inventory.WithRawAsset(item),
-			inventory.WithCloud(inventory.AssetCloud{
-				Provider: inventory.AwsCloudProvider,
-				Region:   item.GetRegion(),
-				Account: inventory.AssetCloudAccount{
-					Id:   f.AccountId,
-					Name: f.AccountName,
-				},
-				Service: &inventory.AssetCloudService{
-					Name: "AWS Networking",
-				},
+			inventory.WithCloud(inventory.Cloud{
+				Provider:    inventory.AwsCloudProvider,
+				Region:      item.GetRegion(),
+				AccountID:   f.AccountId,
+				AccountName: f.AccountName,
+				ServiceName: "AWS Networking",
 			}),
 		)
 	}

internal/inventory/awsfetcher/fetcher_elb_test.go

@@ -69,18 +69,14 @@ func TestELBv1Fetcher_Fetch(t *testing.T) {
 	expected := []inventory.AssetEvent{
 		inventory.NewAssetEvent(
 			inventory.AssetClassificationAwsElbV1,
-			[]string{"arn:aws:elasticloadbalancing:::loadbalancer/my-elb-v1"},
+			"arn:aws:elasticloadbalancing:::loadbalancer/my-elb-v1",
 			"my-elb-v1",
 			inventory.WithRawAsset(asset),
-			inventory.WithCloud(inventory.AssetCloud{
-				Provider: inventory.AwsCloudProvider,
-				Account: inventory.AssetCloudAccount{
-					Id:   "123",
-					Name: "alias",
-				},
-				Service: &inventory.AssetCloudService{
-					Name: "AWS Networking",
-				},
+			inventory.WithCloud(inventory.Cloud{
+				Provider:    inventory.AwsCloudProvider,
+				AccountID:   "123",
+				AccountName: "alias",
+				ServiceName: "AWS Networking",
 			}),
 		),
 	}
@@ -119,18 +115,14 @@ func TestELBv2Fetcher_Fetch(t *testing.T) {
 	expected := []inventory.AssetEvent{
 		inventory.NewAssetEvent(
 			inventory.AssetClassificationAwsElbV2,
-			[]string{"arn:aws:elasticloadbalancing:::loadbalancer/my-elb-v2"},
+			"arn:aws:elasticloadbalancing:::loadbalancer/my-elb-v2",
 			"my-elb-v2",
 			inventory.WithRawAsset(asset),
-			inventory.WithCloud(inventory.AssetCloud{
-				Provider: inventory.AwsCloudProvider,
-				Account: inventory.AssetCloudAccount{
-					Id:   "123",
-					Name: "alias",
-				},
-				Service: &inventory.AssetCloudService{
-					Name: "AWS Networking",
-				},
+			inventory.WithCloud(inventory.Cloud{
+				Provider:    inventory.AwsCloudProvider,
+				AccountID:   "123",
+				AccountName: "alias",
+				ServiceName: "AWS Networking",
 			}),
 		),
 	}