Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16](backport #42315) [streaming] - Made namespace consistent in logging & put a null check to stop paincs on shutdown #42336

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[8.16](backport #42315) [streaming] - Made namespace consistent in logging & put a null check to stop paincs on shutdown #42336

merged 1 commit into from
Jan 17, 2025
+11 −7

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 17, 2025

Type of change

  • Bug

Proposed commit message

  1. Made namespace consistent in suggested debug logs.
  2. Put in a null check during input shutdown to avoid a panic.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42315 done by [Mergify](https://mergify.com).

@ShourieG @mergify
[streaming] - Made namespace consistent in logging & put a null check…
b5fe200 
… to stop paincs on shutdown (#42315)

* made namespace consistent in logging & put a null check to stop paincs on shutdown

(cherry picked from commit ef3bd69)
@mergify mergify bot requested a review from a team as a code owner January 17, 2025 10:02
@mergify mergify bot added the backport label Jan 17, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 17, 2025
@botelastic
Copy link

botelastic bot commented Jan 17, 2025

This pull request doesn't have a Team:<team> label.

@ShourieG ShourieG merged commit 370468d into 8.16 Jan 17, 2025
22 checks passed
@ShourieG ShourieG deleted the mergify/bp/8.16/pr-42315 branch January 17, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@ShourieG ShourieG

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShourieG