-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for collecting and sending function logs to APM Server #303
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nitpicks. Nice work!
f2b6b0d
to
7e6865c
Compare
@axw Apologies for the force push 🙇 This is the commit added for addressing the review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the updates :)
Tested with Verified that the logs are visible in the logs tab in the Observability section. Made sure that Possible concern: #322 |
I'm aware this is still experimental, but some feedback... |
Adds support for collecting
function
logs using AWS Logs API and shipping it to APM-Server with collected agent metadata.Closes: #256